Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMS deprecation warning in JetMETCorrections subsystem #39819

Merged
merged 4 commits into from Oct 24, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • changed modules to edm::one::EDAnalyzer
  • removed unused TauJetCorrector which inherits from a problematic class.

PR validation:

Code compiles without issuing a CMS deprecation warning.

Changed modules to edm::one::EDAnalyzer. This fixes the CMS
deprecation warnings.
Changed to edm::one::EDAnalyzer. This fixes CMS deprecation
warnings in the package.
This fixes the CMS deprecation warning.
The class also inherits from a base class that does not work with
modern framework changes.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39819/32687

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • JetMETCorrections/IsolatedParticles (analysis)
  • JetMETCorrections/MCJet (analysis)
  • JetMETCorrections/TauJet (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/28468/summary.html
COMMIT: c6a932d
CMSSW: CMSSW_12_6_X_2022-10-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39819/28468/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3378384
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3378350
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • RelValInput timing out independently from this PR

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fa01ae4 into cms-sw:master Oct 24, 2022
@Dr15Jones Dr15Jones deleted the deprecatedJetMETCorrections branch November 4, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants