[EGM HLT@Phase2] Move to TICL v4

[swagata87]

PR description:

TICL V4 was introduced by HGCAL DPG by this PR: #38880
However, Phase2 HLT still uses TICL v3.
This PR aims to make the TICL v3->v4 transition for e/gamma HLT in Phase2.
Note that other parts of Phase2 simplified HLT menu (like Jet paths etc) still use TICL v3, and those are not touched in this PR.

PR validation:

runTheMatrix.py -l 39434.75 ran fine.

Measured efficiency of HLT_Ele32 w.r.t gen electrons using this sample: /ZprimeToEE_M-6000_TuneCP5_14TeV-pythia8/PhaseIISpring22DRMiniAOD-PU200_123X_mcRun4_realistic_v11-v1/GEN-SIM-DIGI-RAW-MINIAOD. Made a comparison between TICL v3 and TICL v4. There is some improvement in v4, as seen in the plot, in HGCAL region.

Using the same sample, some showershape variables at HLT were checked. The small changes in shape look okay.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39820/32688

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

Can files like ticlTrackstersEMForEgamma_cfi be removed then?

[swagata87]

indeed, they are not being used anywhere.. so can be removed.
I'll clean it up then

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39820/32695

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #39820 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

test parameters:

• workflows = 20834.76
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a02e97/28436/summary.html
COMMIT: d1cef67
CMSSW: CMSSW_12_6_X_2022-10-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39820/28436/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a02e97/20834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3471515
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3471487
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 48 edm output root files, 49 DQM output files
• TriggerResults: found differences in 2 / 47 workflows

[missirol]

+hlt

• small differences in E/gamma triggers for wfs using the HLT Phase-2 menu (see TriggerResults), which is compatible with the physics changes described in this PR
• link to presentation in HLT-Upgrade meeting

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1