Synchronisation of HCal Config for HLT_75E33 menu (Phase2)

[beaucero]

PR description:

Synchronisation of HCal Configuration for HLT_75E33 menu, the tiny changes in the config are not changing physics results

PR validation:

Running HLT_Simplified_menu Phase2 with the new configuration is successful.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39835/32715

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @beaucero for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

test parameters:

• workflows = 20834.76
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

[missirol]

please test

[missirol]

@beaucero, shouldn't the same update be applied to HLT_75e33/modules/hbhereco_cfi.py, too?

What is the plan to resolve these duplications, and use only the modules named hlt* in the HLT Phase-2 menu?

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1be434/28472/summary.html
COMMIT: 103c58a
CMSSW: CMSSW_12_6_X_2022-10-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39835/28472/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1be434/20834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3471515
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3471493
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 48 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[abdoulline]

Actually I don't see here one more suggested/considered (back in September) "saving time" change:
nMaxItersMin = cms.int32(500), -> nMaxItersMin = cms.int32(50),

(as it's in HLTrigger/Configuration/python/HLT_2022v14_cff.py)

[beaucero]

@missirol Sorry for the delay, loking further indeed, there are quite some duplications of modules which should be removed etc. But we are currently busy with the Annual Review, so cleaning will come later on. Looks likethe second file should be also modified (until it disappears) @abdoulline Sorry for missing the suggestions.
If I understood everything well, a new commit has just been made...

[missirol]

@beaucero , okay, thanks. It looks okay now. For updates like this to the HLT Phase-2 menu, what is currently the target release? This PR updates 12_6_X; for 12_5_X or lower, separate PRs would be needed (after this one is integrated).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39835/32725

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #39835 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[beaucero]

@missirol, no real target as the above changes are not really changing the results of the HLT. I was simply a mis-synchronisation of files which was not nice to carry on propagating. So what is easier to go, we should go for this one. (Same thing when we will do the cleaning, there will be no real release target etc)

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1be434/28499/summary.html
COMMIT: 302b102
CMSSW: CMSSW_12_6_X_2022-10-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39835/28499/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1be434/20834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3471515
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3471490
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 48 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1