Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X] Update alcareco matrix #39837

Merged
merged 1 commit into from Oct 25, 2022

Conversation

malbouis
Copy link
Contributor

PR description:

Backport of PR #38951

This is a simple PR to update the alcareco matrix so that it is in line with the alcareco matrix for tier0.

PR validation:

runTheMatrix.py -l 1001.3,1002.3,1002.4

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of PR #38951

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 24, 2022

A new Pull Request was created by @malbouis for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

test parameters:

  • workflows = 1000,1001,1001.2,1001.3,1002.3,1002.4

@malbouis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edbbed/28479/summary.html
COMMIT: 3b73633
CMSSW: CMSSW_12_4_X_2022-10-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39837/28479/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-edbbed/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-edbbed/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-edbbed/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-edbbed/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 3806546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3806520
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.124 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.020 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.020 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1002.4 ): -0.031 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1002.4 ): -0.031 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 138.5 ): -0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 138.5 ): -0.012 KiB MessageLogger/Warnings
  • Checked 226 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • update ALCARECO matrix to what actually being used in Tier0

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #38951

@perrotta
Copy link
Contributor

+1

  • It brings autoAlca in line with what is currently in master and 12_5_X

@cmsbuild cmsbuild merged commit 83e46c0 into cms-sw:CMSSW_12_4_X Oct 25, 2022
@francescobrivio
Copy link
Contributor

urgent

  • @perrotta @rappoccio I mark this urgent even though it's already merged as this is needed in the next 12_4_X release in order to get the correct ALCARECOs in the 2022ABCD re-reco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants