MTD geometry: fix BTL numbering scheme for DD4hep+Geant4 extra level in path #39843

fabiocos · 2022-10-25T13:33:42Z

PR description:

This PR provide a fix for the crash observed in wf 20834.911 after the integration of #39670 . The use of DD4hep within Geant4 adds effectively one more level in the volume stack, which breaks the logic of the BTL numbering scheme as updated. For this reason an extra protection is added, to address this specific case.

At the same time also the static analyser issue #39670 (review) is addressed.

PR validation:

Test workflows 20834.0, 20834.911 and 23634.911 are correctly executed. Unit tests pass.

cmsbuild · 2022-10-25T13:42:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39843/32724

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-25T13:42:59Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData (geometry, upgrade)
RecoMTD/DetLayers (upgrade, reconstruction)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @mandrenguyen can you please review it and eventually sign? Thanks.
@trtomei, @bsunanda, @beaucero, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2022-10-25T13:46:28Z

test parameters:

workflows = 20834.911,23634.0,23634.911

fabiocos · 2022-10-25T13:46:41Z

please test

cmsbuild · 2022-10-25T14:53:10Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef1843/28490/summary.html
COMMIT: b2e7113
CMSSW: CMSSW_12_6_X_2022-10-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39843/28490/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

21034.999

----- Begin Fatal Exception 25-Oct-2022 16:34:11 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root; Network is unreachable
' (errno=3014, code=400). No additional data servers were found.
      [e] Last URL tried: root://eoscms.cern.ch:1094//store/relval/CMSSW_12_3_0_pre5/RelValMinBias_14TeV/GEN-SIM/123X_mcRun4_realistic_v4_2026D88noPU-v1/10000/b93adc85-715f-477a-afc9-65f3241933ee.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=eb4a9bd2-d368-47fb-9db6-cf5ac063580d
      [f] Problematic data server: eoscms.cern.ch:1094
      [g] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

10024.310024.3_TTbar_13+2017_trackingOnlyRun2+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT/step2_TTbar_13+2017_trackingOnlyRun2+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT.log
10024.010024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step2_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log
10224.1510224.15_TTbar_13+2017PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step2_TTbar_13+2017PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

Expand to see more relval errors ...

perrotta · 2022-10-25T14:57:35Z

urgent

fabiocos · 2022-10-25T15:01:41Z

@perrotta it seems to me that this test failure is unrelated to this PR

srimanob · 2022-10-25T15:22:01Z

Hi @fabiocos

Three additional workflows are not tested. I don't see them in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef1843/28490/runTheMatrix-results/

srimanob · 2022-10-25T15:22:19Z

@cmsbuild please test

Retrigger the test

cmsbuild · 2022-10-25T16:39:44Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef1843/28494/summary.html
COMMIT: b2e7113
CMSSW: CMSSW_12_6_X_2022-10-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39843/28494/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

fabiocos · 2022-10-26T07:37:20Z

I used it for my own private tests, but of course using --what upgrade

perrotta · 2022-10-26T07:39:40Z

test parameters:

workflows = 20834.911

perrotta · 2022-10-26T07:40:16Z

please test
(thank you @smuzaffar )

smuzaffar · 2022-10-26T09:48:08Z

@perrotta , cms-sw/cms-bot#1871 should now properly report such errors too

fabiocos · 2022-10-26T09:56:24Z

@smuzaffar thanks, this is generally useful for the future

cmsbuild · 2022-10-26T11:30:16Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef1843/28514/summary.html
COMMIT: b2e7113
CMSSW: CMSSW_12_6_X_2022-10-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39843/28514/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20834.911 step 3
4.6 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
Reco comparison had 8 failed jobs
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3384029
DQMHistoTests: Total failures: 96
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3383911
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 204 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

fabiocos · 2022-10-26T11:51:26Z

comparison failures look unrelated to this PR

perrotta · 2022-10-26T12:26:35Z

@cms-sw/geometry-l2 @cms-sw/reconstruction-l2 @cms-sw/upgrade-l2 could you please review this PR?
We would like to have it merged in pre4, to get rid of the errors in some Phase2 workflows.

clacaputo · 2022-10-26T13:42:52Z

+reconstruction

srimanob · 2022-10-26T14:31:20Z

+Upgrade

bsunanda · 2022-10-26T14:35:20Z

+geometry

cmsbuild · 2022-10-26T14:35:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-10-26T15:08:43Z

+1

fabiocos added 2 commits October 25, 2022 14:55

Fix BTL numbering for DD4hep additional level in path

f653d1d

Address static analyzer complaint, scram b code-format

b2e7113

cmsbuild added this to the CMSSW_12_6_X milestone Oct 25, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Oct 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 25, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 25, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 25, 2022

cmsbuild added the urgent label Oct 25, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 25, 2022

cmsbuild removed the tests-started label Oct 25, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 26, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 26, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 26, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 26, 2022

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Oct 26, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2022

cmsbuild merged commit df073f5 into cms-sw:master Oct 26, 2022

fabiocos deleted the fc-fixBTLnumbering branch October 26, 2022 16:18

cmsbuild mentioned this pull request Oct 27, 2022

[MkFit] Phase2 geometry & String configurable standard functions #39866

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTD geometry: fix BTL numbering scheme for DD4hep+Geant4 extra level in path #39843

MTD geometry: fix BTL numbering scheme for DD4hep+Geant4 extra level in path #39843

fabiocos commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

fabiocos commented Oct 25, 2022

fabiocos commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

perrotta commented Oct 25, 2022

fabiocos commented Oct 25, 2022

srimanob commented Oct 25, 2022

srimanob commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

fabiocos commented Oct 26, 2022

perrotta commented Oct 26, 2022

perrotta commented Oct 26, 2022

smuzaffar commented Oct 26, 2022

fabiocos commented Oct 26, 2022

cmsbuild commented Oct 26, 2022

fabiocos commented Oct 26, 2022

perrotta commented Oct 26, 2022

clacaputo commented Oct 26, 2022

srimanob commented Oct 26, 2022

bsunanda commented Oct 26, 2022

cmsbuild commented Oct 26, 2022

rappoccio commented Oct 26, 2022

MTD geometry: fix BTL numbering scheme for DD4hep+Geant4 extra level in path #39843

MTD geometry: fix BTL numbering scheme for DD4hep+Geant4 extra level in path #39843

Conversation

fabiocos commented Oct 25, 2022

PR description:

PR validation:

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

fabiocos commented Oct 25, 2022

fabiocos commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

RelVals

RelVals-INPUT

perrotta commented Oct 25, 2022

fabiocos commented Oct 25, 2022

srimanob commented Oct 25, 2022

srimanob commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

RelVals

fabiocos commented Oct 26, 2022

perrotta commented Oct 26, 2022

perrotta commented Oct 26, 2022

smuzaffar commented Oct 26, 2022

fabiocos commented Oct 26, 2022

cmsbuild commented Oct 26, 2022

Comparison Summary

fabiocos commented Oct 26, 2022

perrotta commented Oct 26, 2022

clacaputo commented Oct 26, 2022

srimanob commented Oct 26, 2022

bsunanda commented Oct 26, 2022

cmsbuild commented Oct 26, 2022

rappoccio commented Oct 26, 2022