Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of L1TGlobalProducer to handle fractional prescales [12_5_X] #39851

Merged
merged 3 commits into from Oct 26, 2022

Conversation

missirol
Copy link
Contributor

backport of #39464
backport of #39832

PR description:

This PR backports #39464 and #39832. The first one is a fix by the L1T group to correctly apply fractional prescales in L1T software (needed, for example, for the development of the HIon menu); the 2nd PR is a technical follow-up of the 1st one, adding a unit test and small technical improvements.

Because of #39832, this PR requires the backport of cms-sw/cmsdist#8140 to the 12_5_X branch of cmsdist.

On top of the backports, there is one more commit (844f35a): I had to change the input file of the unit test to use a 12_5_X file.

FYI: @elfontan @mitaylor

PR validation:

The new unit test passes in local tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39464
#39832

Fix for offline trigger studies.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-363f57/28505/summary.html
COMMIT: 844f35a
CMSSW: CMSSW_12_5_X_2022-10-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39851/28505/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 1108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696086
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-363f57/28507/summary.html
COMMIT: 844f35a
CMSSW: CMSSW_12_5_X_2022-10-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39851/28507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 145
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697049
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

This PR should be merged "with" (same IB), or after, cms-sw/cmsdist#8146.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9d0926f into cms-sw:CMSSW_12_5_X Oct 26, 2022
@missirol missirol deleted the fixGlobalBoardForFractPS_125X branch November 1, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants