Enable Puppi photon protection for jets

[ahinzmann]

PR description:

Enable protection of photons in PUPPI jets, i.e. give all PF photons with pT>20 a weight of 1. This is already used in PUPPI MET computation, now added also to jets for consistency. The impact of this change is at less than % level to jet response, resolution, efficiency and purity.

Summary at JME meeting and comparisons:
https://indico.cern.ch/event/1188360/#4-puppi-tuning-neutral-pt-prot
https://indico.cern.ch/event/1209020/#63-puppi-tuning-in-run3

Aim for CMSSW_12_6_0 "Run3 Re-MiniAOD".

PR validation:

scram b runtests
runTheMatrix - l 25.0
No differences observed on 10 events.
Expect tiny difference to only show up in higher pt, like JetHT and QCD_flat samples.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport foreseen.

@nurfikri89

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39861/32761

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

• CommonTools/PileupAlgos (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@missirol, @rappoccio, @gkasieczka, @jdolen, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

type jetmet

[clacaputo]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a2971/28683/summary.html
COMMIT: 2987ada
CMSSW: CMSSW_12_6_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39861/28683/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2261 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416356
• DQMHistoTests: Total failures: 708
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3415626
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

Hi, for puppiJet I see an increase in photon multiplicity' and in photon energy fraction`, which should align with the expectation for this PR (see plots below).

I've also noticed some reco differences in AK8 Jets in some reMiniAOD WFs 136p8311, 137p7611, 136p88811, naively I wouldn’t expect that.

[ahinzmann]

I've also noticed some reco differences in AK8 Jets in some reMiniAOD WFs 136p8311, 137p7611, 136p88811, naively I wouldn’t expect that.

As far as I remember, in these reMiniAOD worksflows, puppi is recomputed, thus also AK8 PUPPI jets may change.

[clacaputo]

8311

Hi @ahinzmann , do you have a reference for it?

[ahinzmann]

8311

Hi @ahinzmann , do you have a reference for it?

these are the relevant lines of code for 136.8311:
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_standard.py#L340
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L3310
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L3301

and the modifier that is picked up to re-run puppi during miniaod production:

cmssw/PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

Line 400 in c3656c5

_run2_miniAOD_ANY = (run2_miniAOD_80XLegacy | run2_miniAOD_94XFall17 | run2_miniAOD_UL)

cmssw/PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

Line 418 in c3656c5

(_run2_miniAOD_ANY | pA_2016 | pp_on_AA).toReplaceWith(task, _rerun_puppijets_task)

cmssw/PhysicsTools/PatAlgos/python/slimming/applySubstructure_cff.py

Line 34 in 6d2f660

(_run2_miniAOD_ANY | pA_2016 ).toReplaceWith(task, _rerun_puppijets_task)

[ahinzmann]

@clacaputo Is this good to go or are there further concerns?

[clacaputo]

+reconstruction

• the PR enable photon protection for jets
• reco differences observed are in agreement with the expectation see here

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[vlimant]

dear all, @ahinzmann @clacaputo ,
our understanding, given what was shown at the xpog jamboree recently is that the change here has downstream impact and make whatever in 12.6 inconsistent : v17-puppi this PR and taggers that are v16-puppi based