Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MkFit] Phase2 geometry & String configurable standard functions #39866

Merged
merged 24 commits into from Nov 21, 2022

Commits on Oct 6, 2022

  1. Copy the full SHA
    a273b50 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    393a9cc View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    5a7c6e8 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    51a92f0 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    3fa8752 View commit details
    Browse the repository at this point in the history
  6. Put write-bin-file dict pcm into top-level directory; remove Ice/ ref…

    …s from MkFitCore/standalone/Makefile; remove obsolete tkNtuple/Makefile (build included in top-level MkFitCMS/standalone/Makefile).
    osschar committed Oct 6, 2022
    Copy the full SHA
    31cf842 View commit details
    Browse the repository at this point in the history
  7. First mkFit runs with Phase2 data / geometry!

    * mkFit.cc: Make use-dead-modules really optional. They are hardcoded
    for CMS-2107, some unknown setup.
    
    * MkBuilder.cc: Make some high-volume debug output optional.
    
    * val_scripts/validation-cmssw-benchmarks-multiiter.sh:
    - Add new sample TTbar_Phase2.
    - Add variable for numiters
    - Make --use-dead-modules configurable
    - Add var for exstra mkFit args to pass in --geom CMS-2029
    - Detect Fedora and use lower n_threads / maxvu. Use AVX2 instead
      of AVX_512. This should be configurable in some other way.
    
    * plotting/Common.hh: Do not try to plot STD in MIMI case - exported
    via an env variable for lack of a better idea.
    We should support STD in MIMI with upcoming configurability changes.
    
    * validation-desc.txt: Add a prelimiary note describing how I ran
    the Phase2 test. Standalone validation has not been tried since the
    move into CMSSW so this should be worked on further.
    
    * xeon_scripts/init-env.sh:
    Detect Fedora and use el8 binaries in this case.
    This should be the default once we drop Centos-7.
    osschar committed Oct 6, 2022
    Copy the full SHA
    6ffe10f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Copy the full SHA
    26d66ba View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Copy the full SHA
    7bf5fdc View commit details
    Browse the repository at this point in the history
  2. * Rename typedefs for duplicate-cleaning functions from filter_duplic…

    …ates to clean_duplicates.
    
    * Rename find_duplicates functions to clean_duplicates prefix.
    
    * Remove obsolete iteration-id dependant steering code.
    osschar committed Oct 19, 2022
    Copy the full SHA
    21cdd1f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Copy the full SHA
    f6b3600 View commit details
    Browse the repository at this point in the history
  2. Final cleanups for std functions, docs.

    * Update README.md with changes / std function name config dexcriptions.
    
    * Move seed-cleaning and duplicate-cleaning parameters out of IterationParams
      into IterationConfig. Prefix them with sc_ and dc_.
    
    * When getting std function by name, throw an exception if name string is
      non-empty and the function does not exist in the registry.
    
    * Add m_layer member to IterationLayerConfig.
    osschar committed Oct 21, 2022
    Copy the full SHA
    406d7ee View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. code-checks and code-format

    osschar committed Oct 26, 2022
    Copy the full SHA
    3b3802d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Copy the full SHA
    58f08ea View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Copy the full SHA
    75f8778 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f714fee View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Use CMS_SA_ALLOW to silence static analyser warnings for static objec…

    …t used for standard function catalogs -- approved by Matti.
    osschar committed Nov 3, 2022
    Copy the full SHA
    821d184 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c964a73 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions by @mmusich to dumpMkFitGeometryPhase2.py, symmetri…

    …ze with the phase1 dumper.
    osschar committed Nov 3, 2022
    Copy the full SHA
    529b93b View commit details
    Browse the repository at this point in the history
  4. Roll back correct mkFit modifiers, extend unit test to also try dumpi…

    …ng the phase2 geometry.
    osschar committed Nov 3, 2022
    Copy the full SHA
    567404c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Copy the full SHA
    60d3d90 View commit details
    Browse the repository at this point in the history
  2. code-checks

    slava77 committed Nov 12, 2022
    Copy the full SHA
    21beaac View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. add clarification comments

    slava77 committed Nov 17, 2022
    Copy the full SHA
    7bbc436 View commit details
    Browse the repository at this point in the history
  2. code-checks

    slava77 committed Nov 17, 2022
    Copy the full SHA
    8ab5c78 View commit details
    Browse the repository at this point in the history