Remove commented unnecessary code from DigiAccumulatorMixModFactory.h

[makortel]

PR description:

As far as I can tell, the commented out part has never been used. My motivation is to remove confusing entries from git grep DEFINE_FWK_PSET_DESC_FILLER.

PR validation:

None

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39877/32798

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• SimGeneral/MixingModule (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28575/summary.html
COMMIT: d6a87a1
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39877/28575/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cecilecaillol [L1T] bugfix, remove duplicate file #39870
• @wddgit Remove deprecated JetPartonCorrector #39848
• @jeongeun Replace Geometry_cff with GeometryDB_cff in MuonAnalysis #39087
• @bsunanda Phase2-hgx327C Delete some of the obsolete files in Geometry/HGCalCommonData/test/python #39871
• @ravindkv duplicated hcalDepthTowerSumEt in GsfElectron.h #39805
• @SohamBhattacharya Switch to TICLv4 for offline HGCAL electrons and photons #39810

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28575/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28575/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1071 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3384029
• DQMHistoTests: Total failures: 2955
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3381052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

@cmsbuild, please test

For cleaner comparisons

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28584/summary.html
COMMIT: d6a87a1
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39877/28584/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cecilecaillol [L1T] bugfix, remove duplicate file #39870
• @wddgit Remove deprecated JetPartonCorrector #39848
• @jeongeun Replace Geometry_cff with GeometryDB_cff in MuonAnalysis #39087
• @bsunanda Phase2-hgx327C Delete some of the obsolete files in Geometry/HGCalCommonData/test/python #39871
• @ravindkv duplicated hcalDepthTowerSumEt in GsfElectron.h #39805
• @SohamBhattacharya Switch to TICLv4 for offline HGCAL electrons and photons #39810

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28584/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee53be/28584/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1075 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3384029
• DQMHistoTests: Total failures: 2955
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3381052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

regression is broken for upgrade WF, but this cannot be connected with this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

trivial