Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made MagFieldConfigDBWriter an edm::one::EDAnalyzer #39887

Merged
merged 1 commit into from Oct 31, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This fixes the CMS deprecation warning.

PR validation:

Code compiles without issuing a CMS deprecation warning.

This fixes the CMS deprecation warning.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39887/32807

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • CondFormats/MFObjects (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c705d2/28604/summary.html
COMMIT: e17311d
CMSSW: CMSSW_12_6_X_2022-10-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39887/28604/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416356
  • DQMHistoTests: Total failures: 93
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416241
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

@Dr15Jones could you explain why there are differences in the JetMET?

@Dr15Jones
Copy link
Contributor Author

@ChrisMisan given that MagFieldConfigDBWriter does not appear in any of the standard configurations, it is pretty safe to say that module is never run in any of the test release validation jobs. So the differences are most likely caused by instability in the reconstruction code itself where it does not always give back the same results when run again.

@mmusich
Copy link
Contributor

mmusich commented Oct 31, 2022

@ChrisMisan

could you explain why there are differences in the JetMET?

you might want to have a look to #39754

@tvami
Copy link
Contributor

tvami commented Oct 31, 2022

+alca

  • technical PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • Technical

@cmsbuild cmsbuild merged commit c6f5398 into cms-sw:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants