Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_5_X] Fix rerecoCommon DQM sequence #39938

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #39934
This PR fixes the @rerecoCommon DQM sequence.

PR validation:

See master PR for the validation

Backport:

Backport of #39934

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_5_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #39934

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

type bug-fix

@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a301d/28700/summary.html
COMMIT: cf127c8
CMSSW: CMSSW_12_5_X_2022-10-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39938/28700/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734344
  • DQMHistoTests: Total failures: 1098
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3733224
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild cmsbuild merged commit 5c7671a into cms-sw:CMSSW_12_5_X Nov 2, 2022
@francescobrivio francescobrivio deleted the alca-fix_autoDQM_12_5_X branch November 2, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants