Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Fix rerecoCommon DQM sequence #39939

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #39934
This PR fixes the @rerecoCommon DQM sequence.

PR validation:

See master PR for the validation

Backport:

Backport of #39934

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Oct 31, 2022
@francescobrivio
Copy link
Contributor Author

backport of #39934

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

please test

  • @francescobrivio do I understand correctly that the actual re-reco will have to use a new release including this fix?

@francescobrivio
Copy link
Contributor Author

please test

* @francescobrivio do I understand correctly that the actual re-reco will have to use a new release including this fix?

Ciao Marco, I think it should be possible to pass the correct commands directly in the driver for the re-reco without the need to wait for a new release (?), but I let @jordan-martins and @cms-sw/dqm-l2 comment further on the exact plans for the rereco.

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

in the driver for the re-reco

e.g. by using @common+@muon+@L1TMon+@hcal+@jetmet+@ecal+@egamma+@L1TMuon+@L1TEgamma+@ctpps instead of the @rerecoCommon shorthand in the DQM and HARVESTING steps?
Looks somewhat error prone...

@francescobrivio
Copy link
Contributor Author

e.g. by using @common+@muon+@L1TMon+@hcal+@jetmet+@ecal+@egamma+@L1TMuon+@L1TEgamma+@ctpps instead of the @rerecoCommon shorthand in the DQM and HARVESTING steps? Looks somewhat error prone...

I agree, but i'm afraid that's the only solution unless we wait for a new 12_4_X release...

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

we wait for a new 12_4_X release..

aren't we expecting anyway one around today to fix prompt and hlt (see #39903)?

@francescobrivio
Copy link
Contributor Author

urgent

  • to be included in next 12_4_X for the re-reco if possible

@cmsbuild cmsbuild added the urgent label Nov 1, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5330a1/28699/summary.html
COMMIT: f31f711
CMSSW: CMSSW_12_4_X_2022-10-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39939/28699/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3719758
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3719734
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jordan-martins
Copy link
Contributor

@cms-sw/dqm-l2 @cms-sw/orp-l2 please, sign this PR. We need to deploy the full reRECO and validation campaign. Thanks,
Jordan

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

type bug-fix

@rvenditti
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

@cms-sw/dqm-l2 can you also sign the master branch PR ASAP? #39934

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild cmsbuild merged commit 66e6b9b into cms-sw:CMSSW_12_4_X Nov 2, 2022
@francescobrivio francescobrivio deleted the alca-fix_autoDQM_12_4_X branch November 2, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants