[10_6_X] Removed duplicated muons in HepMC to G4 interface

[civanch]

PR description:

See #39427
This PR substitute #39436

PR validation:

private

Backport of #39427

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_10_6_X.

It involves the following packages:

• Configuration/Eras (operations)
• SimG4Core/Application (simulation)
• SimG4Core/Generators (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@missirol, @makortel, @rovere, @Martin-Grunewald, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix double counting in HepMC to G4 handoff #39427

[civanch]

backport of #39427

[civanch]

please test

[cmsbuild]

Pull request #39942 was updated. @perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-866525/28682/summary.html
COMMIT: 8cacd8e
CMSSW: CMSSW_10_6_X_2022-10-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39942/28682/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[tvami]

@perrotta @rappoccio this is essentially fully signed now

[perrotta]

Thank you for having provided the modifier that allows this fic being implemented in a closed release cycle.
Let me just check: @tvami @civanch is it fine with you that the name of the parameter is "FinalStateRadiation" and not something like "FixForFinalStateRadiation", which seem more understandable to me?

[tvami]

I agree that FixForFinalStateRadiation is a more clear name indeed.

[cmsbuild]

Pull request #39942 was updated. @perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-866525/28712/summary.html
COMMIT: 2871157
CMSSW: CMSSW_10_6_X_2022-10-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39942/28712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[perrotta]

+1

[perrotta]

ping bot

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will be automatically merged.

[SohamBhattacharya]

Hi, I see that this PR is already in an IB, but I was wondering if (and the timeline if yes) there will be a 10_6_30_patch2, as we would need this patch to proceed with our MC request.
Sorry if this was already discussed and I missed it.

[tvami]

I dont think this was discussed yet, but indeed it would be nice to have a release, I guess we could chat about this at the next ORP, @cms-sw/orp-l2

[SohamBhattacharya]

Hi, I have a naive question:
Is it enough to add --procModifiers run2_final_state_rad to cmsDriver to enable this fix?

[tvami]

Yes, from CMSSW_10_6_31 on

[SohamBhattacharya]

Yes, from CMSSW_10_6_31 on

@tvami Unfortunately that does not seem to work -- the config builder [1] tries to import the modifier from Configuration.ProcessModifiers.run2_final_state_rad_cff and complains that it cannot find a module called run2_final_state_rad_cff, as the modifier actually exists as Configuration.Eras.Modifier_run2_final_state_rad_cff.
Of course when running locally I can just move and rename the modifier file appropriately, but I was wondering how to get this to work with cmsDriver, as that would be needed for central MC requests.

[1] https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_31/Configuration/Applications/python/ConfigBuilder.py#L2105-L2106

[tvami]

:(

would --procModifiers Modifier_run2_final_state_rad_cff work?

[SohamBhattacharya]

:(

would --procModifiers Modifier_run2_final_state_rad_cff work?

Unfortunately not, as the config builder tries to get it from Configuration.ProcessModifiers, whereas this exists under Configuration.Eras.

[tvami]

That's unfortunate, do you want to submit the PR that fixes this, or should I? (And then we'll need a new release [again])

[SohamBhattacharya]

That's unfortunate, do you want to submit the PR that fixes this, or should I? (And then we'll need a new release [again])

I could do it, if that's fine.