Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_5_X] Add new HI Beamspot to the Run-3 HI MC and change vertex smearing to use the estimated HI version #39951

Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 1, 2022

PR description:

Please see #39758

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #39758

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

backport of #39758

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @tocheng, @trtomei, @mmusich, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

test parameters:

  • workflows = 159, 159.02, 159.03

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

urgent

  • should be part of the next 12_5_X

@cmsbuild cmsbuild added the urgent label Nov 1, 2022
@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

Backport of #39758

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

Backport of #39758

this doesnt seem to be registered as a label :/

@francescobrivio
Copy link
Contributor

backport of #39758

@francescobrivio
Copy link
Contributor

Backport of #39758

this doesnt seem to be registered as a label :/

it's the capital "B" the issue :D

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

Hmm but look at this try: #39951 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccf212/28709/summary.html
COMMIT: 8bd4fe7
CMSSW: CMSSW_12_5_X_2022-11-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39951/28709/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ccf212/159.02_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2021PPRECOMBAPPROXCLUSTERS+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO4
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ccf212/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2014 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 3931262
  • DQMHistoTests: Total failures: 12253
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3918987
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 228 log files, 49 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 2 / 52 workflows

@francescobrivio
Copy link
Contributor

+alca

@srimanob
Copy link
Contributor

srimanob commented Nov 2, 2022

+Upgrade

@tvami tvami changed the title Add new HI Beamspot to the Run-3 HI MC and change vertex smearing to use the estimated HI version [12_5_X] Add new HI Beamspot to the Run-3 HI MC and change vertex smearing to use the estimated HI version Nov 2, 2022
@bbilin
Copy link
Contributor

bbilin commented Nov 2, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e68e97 into cms-sw:CMSSW_12_5_X Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants