Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD V10] - Adding correct Iso filter name (without cut values) for Run3 #39956

Merged
merged 1 commit into from Nov 3, 2022

Conversation

wonpoint4
Copy link

Original PR : #39230
Backport PR to 124X : #39894

PR Description:
There is inconsistency between the nanoV10 in 124X and frozen V10 config in master. This PR would make them consistent.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39956/32885

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

A new Pull Request was created by @wonpoint4 (Won Jun) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Nov 2, 2022

please test workflow nano

Thanks a lot @wonpoint4

@swertz
Copy link
Contributor

swertz commented Nov 2, 2022

enable nano

@swertz
Copy link
Contributor

swertz commented Nov 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d6d80/28734/summary.html
COMMIT: e6e0eeb
CMSSW: CMSSW_12_6_X_2022-11-01-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39956/28734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416398
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416376
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.101_mc94Xv2+TTbarMINIAOD9.4v2+NANO_mc9.4v2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.11_data94X2016+MuonEG2016MINIAOD9.4v2+NANO_2016data9.4v2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.12_data94Xv2+MuonEG2017MINIAOD9.4v2+NANO_data9.4v2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.21_data102X+MuonEG2018MINIAOD10.2+NANO_data10.2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.2_mc102X+TTbarMINIAOD10.2+NANO_mc10.2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.301_mc106Xul17+TTbarMINIAOD10.6_UL17v1+NANO_mc10.6ul17v1+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.302_mc106Xul18+TTbarMINIAOD10.6_UL18v1+NANO_mc10.6ul18v1+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.311_mc106Xul17v2+TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.312_mc106Xul17v2+TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.31_mc106Xul17v2+TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.321_data106Xul17+MuonEG2017MINIAOD10.6v1+NANO_data10.6ul17v1+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.322_data106Xul18+MuonEG2018MINIAOD10.6v1+NANO_data10.6ul18v1+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.32_data106Xul16+MuonEG2016MINIAOD10.6v1+NANO_data10.6ul16v1+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.331_data106Xul17v2+MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.332_data106Xul18v2+MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.33_data106Xul16v2+MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.3_mc106Xul16+TTbarMINIAOD10.6_UL16v1+NANO_mc10.6ul16v1+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.401_mc122Xrun3+TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.4_mc122Xrun3_v10+TTbarMINIAOD12.2+NANO_mc12.2_v10+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.501_mc124Xrun3+TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.511_data124Xrun3+MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.51_data124Xrun3_v10+MuonEG2022MINIAOD12.4+NANO_data12.4_v10+HRV_NANO_data
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.5_mc124Xrun3_v10+TTbarMINIAOD12.4+NANO_mc12.4_v10+HRV_NANO_mc
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6d80/2500.6_mc126X_v10+TTBarMINIAOD12.6+NANO_mc12.6_v10+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 28879
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 28857
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 66 log files, 0 edm output root files, 29 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.140 2.140 0.000 ( +0.0% ) 7.05 7.02 +0.4% 1.391 1.387
2500.001 1.119 1.119 0.000 ( +0.0% ) 10.15 10.27 -1.1% 1.368 1.383
2500.1 2.267 2.267 0.000 ( +0.0% ) 5.29 5.30 -0.1% 1.748 1.753
2500.101 2.351 2.351 0.000 ( +0.0% ) 4.46 4.48 -0.4% 1.912 1.911
2500.11 1.212 1.212 0.000 ( +0.0% ) 8.24 8.30 -0.7% 1.574 1.590
2500.12 1.318 1.318 0.000 ( +0.0% ) 6.11 6.11 +0.1% 1.834 1.837
2500.2 2.194 2.194 0.000 ( +0.0% ) 5.28 5.28 -0.0% 1.787 1.783
2500.21 1.210 1.210 0.000 ( +0.0% ) 7.88 7.84 +0.5% 1.833 1.835
2500.3 2.312 2.312 0.000 ( +0.0% ) 5.09 5.10 -0.3% 1.738 1.729
2500.301 2.459 2.459 0.000 ( +0.0% ) 4.64 4.65 -0.1% 1.499 1.497
2500.302 2.412 2.412 0.000 ( +0.0% ) 4.75 4.73 +0.4% 1.798 1.789
2500.31 2.206 2.206 0.000 ( +0.0% ) 8.70 8.71 -0.2% 1.479 1.474
2500.311 2.327 2.327 0.000 ( +0.0% ) 8.28 8.32 -0.5% 1.870 1.861
2500.312 2.278 2.278 0.000 ( +0.0% ) 8.45 8.45 +0.1% 1.855 1.847
2500.32 1.081 1.081 0.000 ( +0.0% ) 9.00 8.93 +0.8% 1.597 1.593
2500.321 1.454 1.454 0.000 ( +0.0% ) 6.03 6.04 -0.1% 1.776 1.775
2500.322 1.227 1.227 0.000 ( +0.0% ) 7.48 7.43 +0.8% 1.498 1.497
2500.33 1.095 1.095 0.000 ( +0.0% ) 19.67 19.86 -1.0% 1.464 1.465
2500.331 1.390 1.390 0.000 ( +0.0% ) 14.77 14.62 +1.1% 1.625 1.622
2500.332 1.322 1.322 0.000 ( +0.0% ) 16.50 16.54 -0.2% 1.557 1.558
2500.4 2.115 2.115 0.000 ( +0.0% ) 9.52 9.58 -0.6% 1.335 1.302
2500.401 2.115 2.115 0.000 ( +0.0% ) 9.60 9.56 +0.4% 1.382 1.352
2500.5 0.302 0.302 0.000 ( +0.0% ) 48.98 49.03 -0.1% 1.183 1.183
2500.501 0.302 0.302 0.000 ( +0.0% ) 48.33 48.25 +0.2% 1.166 1.187
2500.51 1.098 1.098 0.000 ( +0.0% ) 27.39 27.60 -0.8% 1.302 1.302
2500.511 1.098 1.098 0.000 ( +0.0% ) 27.49 27.60 -0.4% 1.305 1.306
2500.6 1.418 1.417 0.000 ( +0.0% ) 22.98 23.30 -1.3% 1.019 1.076
2500.601 1.418 1.418 0.000 ( +0.0% ) 23.85 23.24 +2.6% 1.175 1.176

@swertz
Copy link
Contributor

swertz commented Nov 2, 2022

+1

Only muon trigger objects in nanoV10 workflows change.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • Changes expected in nano.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants