Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.5.X] EMTF DQM fix to remove duplicate x-axis bin labels #39957

Merged
merged 1 commit into from Nov 2, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 2, 2022

resolves #39936

PR description:

Changed DQM plot neighbor labels to avoid duplicates. This meant relabeling DQM plots such as cscDQMOccupancy among others. Chambers with the label "N" became labeled "N1", "N2" ... depending on which sector they preceded.

Change implemented in response to #39936, in which it was discovered that histogram merging is dependent on bin labels in newer ROOT versions, and therefore cannot be duplicate (#25569)

The flag gemChamberBXVFAT.CanExtend was also set to false for consistency with other plots.

PR validation:

First, the issue outlined in #39936 was recreated using the PSet in /afs/cern.ch/user/c/cmst0/public/PausedJobs/HIReplay2022/job_244/job/WMTaskSpace/cmsRun1. Then, the plot labels were changed and new DQMIO files were made with DQMRootOutputModule. These files substituted the input files used in #39936 and the merge was successful.

ROOT files were also created using DQMFileSaverPB to view the plots and ensure that the labels were correct.

This change will also be backported to release CMSSW_12_5_X and 12_5_1_patch1,

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #39952

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2022

backport of #39952

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2022

urgent

  • needs to enter the next 12_5_X release for Tier-0 testing purposes

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f33f54/28733/summary.html
COMMIT: 30b35ce
CMSSW: CMSSW_12_5_X_2022-11-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39957/28733/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734344
  • DQMHistoTests: Total failures: 1009
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3733312
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

histo differences not related to this PR

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild cmsbuild merged commit 0867a1c into cms-sw:CMSSW_12_5_X Nov 2, 2022
@mmusich mmusich deleted the fixDuplicateBinLabels branch November 2, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants