Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WatchRuns restriction on HectorProducer #39978

Merged
merged 1 commit into from Nov 4, 2022
Merged

Remove WatchRuns restriction on HectorProducer #39978

merged 1 commit into from Nov 4, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • The module did nothing on Run transitions so should not restrict the framework's behavior.
  • Also fixed a once per job memory leak.

PR validation:

Code compiles.

@Dr15Jones
Remove WatchRuns restriction on HectorProducer
7826336 
The module did nothing on Run transitions so should not restrict
the framework's behavior.
Also fixed a memory leak.
@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Nov 3, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39978/32907

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • SimTransport/HectorProducer (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

NOTE: I took a quick look at the version of Hector we use in CMSSW and I found a few usages of non-const global variables. It kind of looks like those variables are meant to be set at compile time, but it is not clear. Therefore it is safest to leave HectorProducer as a edm::one::EDProducer (without the globals it would have been good to make it a edm::stream::EDProducer).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ba8f8/28776/summary.html
COMMIT: 7826336
CMSSW: CMSSW_12_6_X_2022-11-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39978/28776/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20834.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416398
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416376
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

civanch
civanch reviewed Nov 3, 2022
View reviewed changes
SimTransport/HectorProducer/src/HectorProducer.cc
@@ -85,30 +82,30 @@ void HectorProducer::produce(edm::Event &iEvent, const edm::EventSetup &es) {
throw cms::Exception("LogicError") << "HectorTrasported HepMCProduce already exists\n";
}

evt_ = new HepMC::GenEvent(*HepMCEvt->GetEvent());
auto evt = new HepMC::GenEvent(*HepMCEvt->GetEvent());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones , should evt be destructed at the exit of this method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO!

@civanch
Copy link
Contributor

civanch commented Nov 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 4, 2022

+1

@cmsbuild cmsbuild merged commit e4a88ee into cms-sw:master Nov 4, 2022
@Dr15Jones Dr15Jones deleted the fixHectorProducer branch November 4, 2022 13:37
@cmsbuild cmsbuild mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@civanch civanch civanch left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @civanch @perrotta