Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FED 1022 to the list passed to rawPrimeDataRepacker #39986

Merged
merged 1 commit into from Nov 8, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 4, 2022

PR description:

Title says it all. Address issue reported at https://github.com/cms-sw/cmssw/pull/39863/files/b225eb3b17720b62ecab1adec8cdb48c538f80e4#r1013955672

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but should be backported to 12.5.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39986/32913

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 4, 2022

test parameters:

  • workflows=159,159.02,159.03,140.56,140.58,140.6

@mmusich
Copy link
Contributor Author

mmusich commented Nov 4, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7acf72/28785/summary.html
COMMIT: fcfe3ba
CMSSW: CMSSW_12_6_X_2022-11-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39986/28785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_230039/jenkins/workspace/compare-root-files-short-matrix/data/PR-7acf72/140.58_RunHI2018+RunHI2018+RAWPRIMEHI18+RECOHID18APPROXCLUSTERS+HARVESTDHI18
  • /pool/condor/dir_230039/jenkins/workspace/compare-root-files-short-matrix/data/PR-7acf72/140.6_RunHI2022+RunHI2022+RAWPRIMEHI22+RECOHID22APPROXCLUSTERS+HARVESTDHI22
  • /pool/condor/dir_230039/jenkins/workspace/compare-root-files-short-matrix/data/PR-7acf72/159.02_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2021PPRECOMBAPPROXCLUSTERS+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO4
  • /pool/condor/dir_230039/jenkins/workspace/compare-root-files-short-matrix/data/PR-7acf72/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3717902
  • DQMHistoTests: Total failures: 18012
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3699868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 29.356 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 140.6 ): 27.582 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 140.6 ): 1.774 KiB SiStrip/MechanicalView
  • Checked 230 log files, 48 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@mmusich mmusich deleted the from-CMSSW_12_6_X_2022-11-03-2300 branch November 8, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants