Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premix relvals: adapt to fixes of premixing #4001

Conversation

franzoni
Copy link

. process string set to differentiate 25ns/50ns pilep overlaid when done with premixed events (affects only wf injection to reqmgr)
. --geometry Extended2015 as needs be in the 70x (all GT-driven in subsequent releases)
. introduced SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing wherever needed by premix workflows to adapt to Mike's #3973; ** TEMPORARY **

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni for CMSSW_7_0_X.

premix relvals: adapt to fixes of premixing

It involves the following packages:

Configuration/PyReleaseValidation

@nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #4001 was updated. @nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@franzoni
Copy link
Author

+1
--what pileup and --what premix tests all ok
(except the two premix PROD wf's, as expected, which need a new neutrino gun sample to pick up Mike's fix; in process)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@franzoni
Copy link
Author

I managed to get all tests pass in local test 2 days ago.
Now the datasets which are needed in input are gone https://hypernews.cern.ch/HyperNews/CMS/get/relval/2998/1/1/1/1.html thus all tests would fail. This is why I am holding up the plusOne now. I'll keep an eye on this for the next day
@srimanob could you please plusOne this PR, if needs be, once the datasets will be back (I'll be offline for 2 weeks starting this Sat)?

@cmsbuild
Copy link
Contributor

Pull request #4001 was updated. @nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

…sure RECO of prod premix workflows use consistent GT
@franzoni
Copy link
Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Jun 10, 2014
…00-premixPROD2

premix relvals: adapt to fixes of premixing
@davidlange6 davidlange6 merged commit 5e8c47d into cms-sw:CMSSW_7_0_X Jun 10, 2014
@ktf ktf mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants