fix `gcc11` compilation issues in `CompareAlignments`, post #38304 merge #40019

mmusich · 2022-11-09T08:08:01Z

PR description:

Minimal set of fixes, to avoid compilation issues with Alignment/OfflineValidation in gcc11 IBs, post #38304 merge (see IB logs )

PR validation:

cmssw compiles in el8_amd64_gcc11

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@TomasKello, please cross-check

mmusich · 2022-11-09T08:08:10Z

type bug-fix

mmusich · 2022-11-09T08:08:20Z

urgent

to avoid having a broken IB

cmsbuild · 2022-11-09T08:17:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40019/32973

This PR adds an extra 16KB to repository

cmsbuild · 2022-11-09T08:18:22Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-11-09T08:18:54Z

@cmsbuild, please test

cmsbuild · 2022-11-09T09:46:50Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e90e/28901/summary.html
COMMIT: 2030dbb
CMSSW: CMSSW_12_6_X_2022-11-08-2000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e90e/28901/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e90e/28901/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test runtestRecoEgammaPhotonIdentification had ERRORS
---> test PVall had ERRORS
---> test DMRall had ERRORS

RelVals

136.8311

----- Begin Fatal Exception 09-Nov-2022 09:53:18 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/RunIII_Winter22/PhoMVA_ID_EB_V1.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 09-Nov-2022 09:53:18 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/RunIII_Winter22/PhoMVA_ID_EB_V1.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM
----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 09-Nov-2022 09:53:21 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PhotonMVAValueMapProducer label='photonMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/PhotonIdentification/data/MVA/RunIII_Winter22/PhoMVA_ID_EB_V1.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28901/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02758/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-11-08-2000/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

Expand to see more relval errors ...

mmusich · 2022-11-09T09:50:01Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT

RelVals RelVals-INPUT are failing because of Photon MVA-based ID for Run3 from EGamma POG #39927 (comment)
Not clear to me why unit tests are failing, see question at Large files used by new All-in-one Tool cms-data/Alignment-OfflineValidation#3 (comment)

mmusich · 2022-11-09T12:57:43Z

@cmsbuild, please test

let's use the new IB

rappoccio · 2022-11-09T14:53:43Z

@smuzaffar the IB inputs are still failing due to this, do you think they will clear if we restart them?

aandvalenzuela · 2022-11-09T15:26:02Z

please test

tests seem stuck

Alignment/OfflineValidation/src/CompareAlignments.cc

mmusich · 2022-11-10T07:13:59Z

test parameters:

addpkg = DQM/TrackerMonitorTrack

mmusich · 2022-11-10T07:14:16Z

@cmsbuild, please test for CMSSW_12_6_X/el8_amd64_gcc11

mmusich · 2022-11-10T07:18:16Z

In a local installation

git cms-addpkg DQM/TrackerMonitorTrack
scramv1 b -j 20
voms-proxy-init -voms cms
edmPluginHelp -p MonitorTrackResiduals | head -1

yields:

1  MonitorTrackResiduals  (stream::EDProducer)  "pluginDQMTrackerMonitorTrack.so"

then:

runTheMatrix.py -l 4.22 --ibeos

gives:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Thu Nov 10 08:13:25 2022-date Thu Nov 10 08:07:14 2022; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

cmsbuild · 2022-11-10T08:22:38Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e90e/28941/summary.html
COMMIT: 4136730
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28941/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

138.4

----- Begin Fatal Exception 10-Nov-2022 08:35:49 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'SiPixelPhase1RecHits' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 10-Nov-2022 08:35:52 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'SiPixelPhase1RecHits' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

136.793

----- Begin Fatal Exception 10-Nov-2022 08:37:52 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'SiPixelPhase1RecHits' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

mmusich · 2022-11-10T08:26:41Z

test parameters:

addpkg = DQM/TrackerMonitorTrack, DQM/SiPixelPhase1Track

mmusich · 2022-11-10T08:26:54Z

@cmsbuild, please test for CMSSW_12_6_X/el8_amd64_gcc11

mmusich · 2022-11-10T10:29:46Z

@cms-sw/alca-l2 it is clear now that this PR solves the issues in compilation in gcc11 when all the dependent packages are compiled together. Please sign urgently.

francescobrivio · 2022-11-10T10:59:50Z

+alca

the concern about endless while loop has been addressed by the last force-push 4136730

cmsbuild · 2022-11-10T11:00:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2022-11-10T11:06:29Z

@cms-sw/orp-l2 , if you merge this then I can force start a GCC11 IB

cmsbuild · 2022-11-10T11:53:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e90e/28945/summary.html
COMMIT: 4136730
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40019/28945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6355 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416447
DQMHistoTests: Total failures: 21288
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3395137
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

rappoccio · 2022-11-10T13:39:05Z

+1

Fingers crossed this clears! :)

rappoccio · 2022-11-10T13:39:31Z

@cms-sw/orp-l2 , if you merge this then I can force start a GCC11 IB

Thanks @smuzaffar, please force build.

rappoccio · 2022-11-10T21:28:09Z

The IBs seem to be happy now, thanks!

cmsbuild added this to the CMSSW_12_6_X milestone Nov 9, 2022

cmsbuild added alca-pending bug-fix code-checks-pending orp-pending pending-signatures tests-pending urgent labels Nov 9, 2022

mmusich changed the title ~~fix compilation issues in CompareAlignments, post #38304 merge~~ fix compilation issues in CompareAlignments, post #38304 merge Nov 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2022

mmusich mentioned this pull request Nov 9, 2022

Large files used by new All-in-one Tool cms-data/Alignment-OfflineValidation#3

Merged

cmsbuild added tests-rejected and removed tests-started labels Nov 9, 2022

mmusich changed the title ~~fix compilation issues in CompareAlignments, post #38304 merge~~ fix gcc11 compilation issues in CompareAlignments, post #38304 merge Nov 9, 2022

cmsbuild added tests-started and removed tests-rejected labels Nov 9, 2022

Dr15Jones reviewed Nov 9, 2022

View reviewed changes

Alignment/OfflineValidation/src/CompareAlignments.cc Show resolved Hide resolved

cmsbuild added tests-started and removed tests-rejected labels Nov 10, 2022

cmsbuild added tests-rejected and removed tests-started labels Nov 10, 2022

cmsbuild added tests-started and removed tests-rejected labels Nov 10, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 10, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 10, 2022

cmsbuild merged commit 193adba into cms-sw:master Nov 10, 2022

mmusich deleted the fixAlignmentOfflineValidationCompilationEL8 branch November 10, 2022 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix `gcc11` compilation issues in `CompareAlignments`, post #38304 merge #40019

fix `gcc11` compilation issues in `CompareAlignments`, post #38304 merge #40019

mmusich commented Nov 9, 2022 •

edited

mmusich commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

mmusich commented Nov 9, 2022

mmusich commented Nov 9, 2022 •

edited

rappoccio commented Nov 9, 2022

aandvalenzuela commented Nov 9, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

francescobrivio commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

smuzaffar commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

rappoccio commented Nov 10, 2022

rappoccio commented Nov 10, 2022

rappoccio commented Nov 10, 2022

fix gcc11 compilation issues in CompareAlignments, post #38304 merge #40019

fix gcc11 compilation issues in CompareAlignments, post #38304 merge #40019

Conversation

mmusich commented Nov 9, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

mmusich commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

Unit Tests

RelVals

RelVals-INPUT

mmusich commented Nov 9, 2022

mmusich commented Nov 9, 2022 • edited

rappoccio commented Nov 9, 2022

aandvalenzuela commented Nov 9, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

RelVals

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

mmusich commented Nov 10, 2022

francescobrivio commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

smuzaffar commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

Comparison Summary

rappoccio commented Nov 10, 2022

rappoccio commented Nov 10, 2022

rappoccio commented Nov 10, 2022

fix `gcc11` compilation issues in `CompareAlignments`, post #38304 merge #40019

fix `gcc11` compilation issues in `CompareAlignments`, post #38304 merge #40019

mmusich commented Nov 9, 2022 •

edited

mmusich commented Nov 9, 2022 •

edited