Fix JMENano, further cleanup in Nano #40033

swertz · 2022-11-09T16:01:22Z

PR description:

Fix relval crash in JMENano workflows reported in NANO configuration Cleanup #39796 (comment)
Further remove unused variables and modules from NanoAOD, follow-up of NANO configuration Cleanup #39796

PR validation:

Ran with runTheMatrix.py --what nano --site "" --command "--number 10" -l 2500.4,2500.401 and runTheMatrix.py -l 11024.15 --sites '' --ibeos

cmsbuild · 2022-11-09T16:10:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40033/32980

This PR adds an extra 28KB to repository
Found files with invalid states:
- PhysicsTools/NanoAOD/plugins/BTagSFProducer.cc:
  - Deleted: c729e84
  - Added: 2022b46
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40033/32980/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40033/32980/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-11-09T20:27:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40033/32984

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034

cmsbuild · 2022-11-09T20:27:30Z

A new Pull Request was created by @swertz (Sébastien Wertz) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

swertz · 2022-11-10T08:26:36Z

enable nano

swertz · 2022-11-10T08:26:44Z

please test

cmsbuild · 2022-11-10T11:47:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-423b75/28944/summary.html
COMMIT: 69f178d
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40033/28944/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416447
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3416419
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.311_mc106Xul17v2+TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.312_mc106Xul17v2+TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.31_mc106Xul17v2+TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.331_data106Xul17v2+MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.332_data106Xul18v2+MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.33_data106Xul16v2+MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.401_mc122Xrun3+TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.4_mc122Xrun3_v10+TTbarMINIAOD12.2+NANO_mc12.2_v10+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.501_mc124Xrun3+TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.511_data124Xrun3+MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.51_data124Xrun3_v10+MuonEG2022MINIAOD12.4+NANO_data12.4_v10+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.5_mc124Xrun3_v10+TTbarMINIAOD12.4+NANO_mc12.4_v10+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-423b75/2500.6_mc126X_v10+TTBarMINIAOD12.6+NANO_mc12.6_v10+HRV_NANO_mc

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 14740
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 14740
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 0 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.204	2.210	-0.006 ( -0.3% )	9.15	9.20	-0.5%	1.471	1.520
2500.311	2.324	2.331	-0.006 ( -0.3% )	8.88	8.88	+0.0%	1.842	1.886
2500.312	2.276	2.282	-0.006 ( -0.3% )	8.92	8.82	+1.2%	1.834	1.879
2500.33	1.099	1.099	0.000 ( +0.0% )	21.33	21.50	-0.8%	1.642	1.641
2500.331	1.396	1.396	0.000 ( +0.0% )	15.80	15.48	+2.0%	1.805	1.806
2500.332	1.328	1.328	0.000 ( +0.0% )	17.61	17.54	+0.4%	1.751	1.747
2500.4	2.115	2.115	0.000 ( +0.0% )	9.76	9.81	-0.5%	1.405	1.433
2500.401	2.113	2.119	-0.005 ( -0.3% )	9.85	9.59	+2.7%	1.180	1.230
2500.5	0.302	0.302	0.000 ( +0.0% )	50.06	50.68	-1.2%	1.138	1.172
2500.501	0.302	0.302	-0.000 ( -0.0% )	50.64	50.91	-0.5%	1.130	1.172
2500.51	1.100	1.100	0.000 ( +0.0% )	27.62	27.98	-1.3%	1.398	1.434
2500.511	1.104	1.104	0.000 ( +0.0% )	27.56	28.11	-1.9%	1.398	1.431
2500.6	1.418	1.418	0.000 ( +0.0% )	23.23	22.86	+1.6%	1.105	1.143
2500.601	1.422	1.422	0.000 ( +0.0% )	23.14	22.77	+1.6%	1.108	1.145

swertz · 2022-11-10T12:08:37Z

+1

cmsbuild · 2022-11-10T12:09:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-11-10T16:38:20Z

+1

Technical PR

define hfjetshowershape in custom_jme

136e262

cmsbuild added this to the CMSSW_12_6_X milestone Nov 9, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Nov 9, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 9, 2022

cmsbuild mentioned this pull request Nov 9, 2022

HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034

Closed

swertz added 2 commits November 9, 2022 21:18

remove btag SF branch from nanoAOD

75a46ae

remove unused modules from nanoAOD

69f178d

swertz force-pushed the fixNano_from-CMSSW_12_6_X_2022-11-08-2300 branch from 2022b46 to 69f178d Compare November 9, 2022 20:18

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2022

swertz changed the title ~~WIP: Fix JMENano, further cleanup in Nano~~ Fix JMENano, further cleanup in Nano Nov 10, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2022

cmsbuild removed the pending-signatures label Nov 10, 2022

cmsbuild added fully-signed xpog-approved and removed xpog-pending labels Nov 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 10, 2022

cmsbuild merged commit 4df8cfe into cms-sw:master Nov 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JMENano, further cleanup in Nano #40033

Fix JMENano, further cleanup in Nano #40033

swertz commented Nov 9, 2022 •

edited

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

swertz commented Nov 10, 2022

swertz commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

swertz commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

rappoccio commented Nov 10, 2022

Fix JMENano, further cleanup in Nano #40033

Fix JMENano, further cleanup in Nano #40033

Conversation

swertz commented Nov 9, 2022 • edited

PR description:

PR validation:

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

swertz commented Nov 10, 2022

swertz commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

Comparison Summary

NANO Comparison Summary

swertz commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

rappoccio commented Nov 10, 2022

swertz commented Nov 9, 2022 •

edited