Run3-sim136 Extend the testing of wrong cell assignments in HCAL

[bsunanda]

PR description:

Extend the testing of wrong cell assignments in HCAL

PR validation:

Use the scripts to test workflows for different run periods.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40035/32989

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40035/32989/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40035/32989/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40035/32990

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6abba4/28939/summary.html
COMMIT: f6ccd86
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40035/28939/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416447
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416425
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , what is a bit worrying me that the test now become mixed with production in HCalSD, for example, in production we call

if (testNumber) {

for normal hits. Ideally debugging and tests should be maximally disentangle from ordinary computations. I would even add extra methods to the class and
within ifdef only call these methods. Inside these new methods may be LogVerbatim, filling of arrays, printouts. When everything mix together the probability of bugs increases. I also do not understand why you have different key to enable debugging. I would left ML_DEBUG for all type of debugs and do not add printdebug, because the level of printout is defined by configuration. You will not have extra printout if you do not want.

[civanch]

These my comments mainly to run time methods.

[civanch]

At least, in HCalSD there are lines 456 and 473, where test is mixed with normal processing.

[bsunanda]

@civanch testNumber is used to include layer # in the unitID and not the Set (which is used for run 1 simulation) - there were cases when no neutral density filter was used (most of Run2 and all Run3/Run4 configuration). But it was used for legacy code . So we had to have this test. This is not for any testing of the code. I think the name "testNumberingScheme" is a bit misleading. I used initially for doing the test and some people found it useful when Run2 started and asked to utilise the feature

[bsunanda]

@civanch All tests are protected by EDM_ML_DEBUG, plotDebug or printDebug. testNumber is not a test - it is a switch which is used to distinguish Run1 and part of Run2 with tthe most of Run2 and beyond.

[civanch]

+1

@bsunanda , the name is really misleading - let us not find better name in this PR, because it only includes "printdebug"

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

Hi Vladimir I am planning to change the name HcalTestNumbering to something like HcalExtendedNumbering - not to confuse for future versions. I shall do that in view of 13_0_X. People need not use my memory for future HCAL versions. Regards Sunanda

…

________________________________ From: Vladimir Ivantchenko ***@***.*** Sent: 11 November 2022 10:35 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-sim136 Extend the testing of wrong cell assignments in HCAL (PR #40035) +1 @bsunanda<https://github.com/bsunanda> , the name is really misleading - let us not find better name in this PR, because it only includes "printdebug" — Reply to this email directly, view it on GitHub<#40035 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUBQHE6DY2RT47TP5TWHYHO7ANCNFSM6AAAAAAR4B7L2M>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[civanch]

Hi Sunanda, It is also possible to include "Run2" or year in the new name.

[rappoccio]

+1