Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ThroughputService and FastTimerService DQM folders [12.4.x] #40065

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 14, 2022

PR description:

Include the information about whether Simultaneous Multi Threading (SMT) is enabled or disabled after the processor model name.

Fix the DQM folder used by the ThroughputService to take into account the processor model name (and the SMT status) if the corresponding flag is enabled.

PR validation:

The processor model name and the SMT status not appear correctly in the DQM folder names for the FastTimerService and ThroughputService:

image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40062 to 12.4.x for data taking.

Include whether Simultaneous Multi Threading (SMT) is enabled or
disabled after the processor model name.
Properly take into account the processor model name and SMT status in
the DQM folder for the ThroughputService
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 14, 2022

backport #40062

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 15, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #40065 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 15, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-249e4e/29017/summary.html
COMMIT: 27815f8
CMSSW: CMSSW_12_4_X_2022-11-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40065/29017/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3720277
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3720247
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Nov 15, 2022
@missirol
Copy link
Contributor

urgent

Labelling this like the other PRs targeting the next 12_4_X release (this PR is relevant to online ops).
CMSSW_12_6_X_2022-11-16-1100 includes this update, and doesn't show any issue related to it.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0d52554 into cms-sw:CMSSW_12_4_X Nov 17, 2022
@fwyzard fwyzard deleted the fix_ThroughputService_and_FastTimerService_DQM_folders branch March 9, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants