Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on GE21 online/offlineDQM plots with division on modules, a backport to 12_5_X #40071

Closed
wants to merge 3 commits into from

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Nov 15, 2022

PR description:

This PR provides massive updates on GE21 onlineDQM/offlineDQM plots. This work is focusing on the division of GE21 information by modules (M1-M4). It is necessary because of the electronic configuration of GE21 chambers.

It is also included that the module information is propagated to the GEM unpacker in a better way, which is done by @yeckang.

PR validation:

Tests are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=361054 dataset=/ExpressPhysics/Run2022F-Express-v1/FEVT and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5 and reconstruction

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #39985 to 12_5_X.

@jshlee @watson-ij @seungjin-yang @yeckang

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2022

A new Pull Request was created by @quark2 for CMSSW_12_5_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DataFormats/GEMDigi (upgrade, simulation)
  • EventFilter/GEMRawToDigi (reconstruction)

@civanch, @clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @jshlee, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type gem

@cmsbuild cmsbuild added the gem label Nov 16, 2022
@emanueleusai
Copy link
Member

backport of #39985

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

hold

  • this backport is not to be merged since it contains changes to reco. This backport is only for the deployment to DQM online systems

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @emanueleusai
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Nov 16, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62173d/29027/summary.html
COMMIT: 78a9d01
CMSSW: CMSSW_12_5_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40071/29027/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 153
  • DQMHistoTests: Total successes: 3734635
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14085.166000000001 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -1.219 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): -34.328 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): 2.953 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 11634.0,... ): 0.914 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 11634.0,... ): -0.094 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 23234.0,... ): -1086.375 KiB GEM/Digis
  • DQMHistoSizes: changed ( 23234.0,... ): 4.219 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 23234.0,... ): -2.500 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 23234.0,... ): 1.125 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 35034.0 ): ...
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

Tested at p5 using HI run 361697 and pp run 361197. The former run didn't cause a crash but since in that run GEM was on standby, we see the change of DQM plots in the test with 361197.

@emanueleusai
Copy link
Member

+1

  • differences in GEM DQM plots as expected

@perrotta
Copy link
Contributor

As discussed and agreed with DQM and all other groups present at the ORP meeting on Dec 13, we can now close this PR (which will never be merged in the offline release anyhow) and clean up a bit our queues

@perrotta perrotta closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants