Protect against particles with zero weight and pt being given as input to njettiness BACKPORT

[laurenhay]

PR description:

As discussed in issue #40032 , BoostedDoubleSVProducer caused an abort signal in a reco job.
We found that there were unrealistic kinematic values in fjParticles being input to njettiness and are protecting against it by requiring a nonzero weight and pt > epsilon.

PR validation:

Verified that this fix solves the issues in CMSSW_12_4_10_patch3 and ran usual code check and that basic runTheMatrix workflows run.

@rappoccio

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #40081
Backport is needed so that the reco jobs being stopped can be run

[cmsbuild]

A new Pull Request was created by @laurenhay (Lauren Hay) for CMSSW_12_4_X.

It involves the following packages:

• RecoBTag/SecondaryVertex (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Protect against particles with zero weight and pt being given as input to njettiness #40081

[francescobrivio]

@cmsbuild please test

[francescobrivio]

urgent

• to be included in next 12_4_X (attn. of the ORM @ebrondol)
• I tested this on the failing job and it runs succesfull as detailed in Abort signal in PromptReco for JetMET in run 361468 #40032 (comment)

[mandrenguyen]

Backport of #40081

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e12942/29057/summary.html
COMMIT: be4b045
CMSSW: CMSSW_12_4_X_2022-11-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40088/29057/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3720277
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3720247
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

please test
We seem to be getting a lot of timeouts. Could it be worth reviewing the workflows to see if any can be removed?

[rappoccio]

Since we'd really like to cut the next 12_4 release, I think it is relatively safe to put this through anyway. The tests all passed in 12_6 and this is verified privately to fix the error in prompt reco. The current errors are in timeouts again can probably be safely ignored for this PR.

[perrotta]

please test We seem to be getting a lot of timeouts. Could it be worth reviewing the workflows to see if any can be removed?

@mandrenguyen please don't bother about relval inputs timeouts: they appear quite often, no need to restart the tests for them.
Previous tests were succesfull then, and you already signed the master version of this PR, which is now running fine in the IBs : we can probably merge this backport now and start building 12_4_11_patch1 afterwards

[perrotta]

+1

• See above

[perrotta]

@laurenhay while we are merging this in 12_4_X to gain time, we definitely need the same backport also for 12_5_X

I see that another fix is being prepared and submitted to master: #40093: hopefully we won't need to wait for that one too!

[rappoccio]

12_5 backport is here: #40092

[perrotta]

merge

[rappoccio]

Forcing merge here so we can get started on 12_4_11_patch1

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e12942/29102/summary.html
COMMIT: be4b045
CMSSW: CMSSW_12_4_X_2022-11-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40088/29102/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3720277
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3720253
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found