New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix initialization of local variables to avoid vagrind warnings #40105
fix initialization of local variables to avoid vagrind warnings #40105
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40105/33089
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e746d/29120/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes the initialization of a couple of MPlex arrays allocated on the stack. Previously they were being initialized up to N_proc, which may be smaller than the full vector width NN. This PR ensures that any MPlex entries past N_proc are initialized to zero, since many of the propagation loops go up to NN to aid vectorization.
PR validation:
Reran valgrind and verified that there were no MkFit warnings.