[12_5_X] Fix HI rawDataInputTag for beamhlt DQM client #40108

francescobrivio · 2022-11-18T16:26:53Z

PR description:

Backport of #40109

This PR fixes the crash observed during HeavyIon data-taking in the online DQM client beamhlt:

----- Begin Fatal Exception 18-Nov-2022 16:45:53 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 362293 lumi: 14 event: 15139921 stream: 0
   [1] Running path 'p'
   [2] Calling method for module ScalersRawToDigi/'scalersRawToDigi'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: FEDRawDataCollection
Looking for module label: rawDataRepacker
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

The issue arises from the fact that the streamDQMOnlineBeamspot does not contain rawDataRepacker, but:

OutputModule: hltOutputDQMOnlineBeamspot
    Datasets:
         Dataset_DQMOnlineBeamspot
    Event Content:
         drop *
         keep *_hltFEDSelectorOnlineMetaData_*_*
         keep *_hltFEDSelectorTCDS_*_*
         keep edmTriggerResults_*_*_*
         keep recoTracks_hltPFMuonMergingPPOnAA_*_*
         keep recoVertexs_hltVerticesPFFilterPPOnAA_*_*

This PR adds the correct rawDataInputTag for the HI case.

PR validation:

None, to be tested online in P5

Backport:

backport of #40109

francescobrivio · 2022-11-18T16:27:01Z

type bug-fix

cmsbuild · 2022-11-18T16:27:17Z

A new Pull Request was created by @francescobrivio for CMSSW_12_5_X.

It involves the following packages:

DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Fix HI rawDataInputTag for beamhlt DQM client #40109

francescobrivio · 2022-11-18T16:29:54Z

@cmsbuild please test

francescobrivio · 2022-11-18T16:44:42Z

backport of #40109

tvami · 2022-11-18T17:51:29Z

urgent

syuvivida · 2022-11-18T18:00:11Z

+1

cmsbuild · 2022-11-18T18:00:35Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2022-11-18T19:20:39Z

DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py

@@ -134,7 +134,7 @@

 # Set rawDataRepacker (HI and live) or hltFEDSelectorTCDS+hltFEDSelectorOnlineMetaData (for all the rest)
 if (process.runType.getRunType() == process.runType.hi_run and live):
-    rawDataInputTag = "rawDataRepacker"
+    rawDataInputTag = "hltFEDSelectorTCDS"


see comment in master https://github.com/cms-sw/cmssw/pull/40109/files#r1026796774

cmsbuild · 2022-11-18T20:04:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e90a/29121/summary.html
COMMIT: a95cf26
CMSSW: CMSSW_12_5_X_2022-11-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40108/29121/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3734871
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3734847
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 216 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

perrotta · 2022-11-19T08:56:44Z

@francescobrivio since the HI run is going to end in short, I imagine that you do not expect this being actually merged in the release. Taking also into account that the master version still needs to converge, as it was also pointed out above.
Then I also imagine that your "urgent" fleg just wants to tell to DQM: "please add it to the online DQM release for the HI data taking in order to prevent the crash"...

syuvivida · 2022-11-19T09:04:27Z

@perrotta We already deployed this PR in online DQM machine.

cmsbuild · 2022-11-20T21:26:37Z

Pull request #40108 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

francescobrivio · 2022-11-20T21:26:48Z

@cmsbuild please test

francescobrivio · 2022-11-20T21:29:32Z

@francescobrivio since the HI run is going to end in short, I imagine that you do not expect this being actually merged in the release. Taking also into account that the master version still needs to converge, as it was also pointed out above. Then I also imagine that your "urgent" fleg just wants to tell to DQM: "please add it to the online DQM release for the HI data taking in order to prevent the crash"...

Hi Andrea, in the last push (fb26867) I backported the modification to address the comment received in master. Even though HI run is already finished, since this PR was deployed online during the HI data-taking, I believe it would be good to merge this PR as well to have everything documented and up to date in the release.

cmsbuild · 2022-11-21T01:00:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1e90a/29148/summary.html
COMMIT: fb26867
CMSSW: CMSSW_12_5_X_2022-11-20-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40108/29148/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3734871
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3734847
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 216 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-11-21T11:25:38Z

+1

cmsbuild · 2022-11-21T11:25:59Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-11-22T10:38:01Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Nov 18, 2022

cmsbuild added bug-fix dqm-pending orp-pending pending-signatures tests-pending labels Nov 18, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 18, 2022

francescobrivio mentioned this pull request Nov 18, 2022

Fix HI rawDataInputTag for beamhlt DQM client #40109

Merged

cmsbuild added the backport label Nov 18, 2022

cmsbuild added the urgent label Nov 18, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 18, 2022

mmusich reviewed Nov 18, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 18, 2022

Fix rawDataInputTag for beamhlt DQM client for both pp and HI

fb26867

francescobrivio force-pushed the alca-fix_beamhlt_HI_12_5_X branch from a95cf26 to fb26867 Compare November 20, 2022 21:26

cmsbuild added dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-approved labels Nov 20, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 20, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 21, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 21, 2022

cmsbuild added backport-ok and removed backport labels Nov 21, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 22, 2022

cmsbuild merged commit b5d7c97 into cms-sw:CMSSW_12_5_X Nov 22, 2022

francescobrivio deleted the alca-fix_beamhlt_HI_12_5_X branch December 5, 2022 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_5_X] Fix HI rawDataInputTag for beamhlt DQM client #40108

[12_5_X] Fix HI rawDataInputTag for beamhlt DQM client #40108

francescobrivio commented Nov 18, 2022 •

edited

francescobrivio commented Nov 18, 2022

cmsbuild commented Nov 18, 2022 •

edited

francescobrivio commented Nov 18, 2022

francescobrivio commented Nov 18, 2022

tvami commented Nov 18, 2022

syuvivida commented Nov 18, 2022

cmsbuild commented Nov 18, 2022

mmusich Nov 18, 2022

cmsbuild commented Nov 18, 2022

perrotta commented Nov 19, 2022

syuvivida commented Nov 19, 2022

cmsbuild commented Nov 20, 2022

francescobrivio commented Nov 20, 2022

francescobrivio commented Nov 20, 2022

cmsbuild commented Nov 21, 2022

emanueleusai commented Nov 21, 2022

cmsbuild commented Nov 21, 2022

perrotta commented Nov 22, 2022

[12_5_X] Fix HI rawDataInputTag for beamhlt DQM client #40108

[12_5_X] Fix HI rawDataInputTag for beamhlt DQM client #40108

Conversation

francescobrivio commented Nov 18, 2022 • edited

PR description:

PR validation:

Backport:

francescobrivio commented Nov 18, 2022

cmsbuild commented Nov 18, 2022 • edited

francescobrivio commented Nov 18, 2022

francescobrivio commented Nov 18, 2022

tvami commented Nov 18, 2022

syuvivida commented Nov 18, 2022

cmsbuild commented Nov 18, 2022

mmusich Nov 18, 2022

Choose a reason for hiding this comment

cmsbuild commented Nov 18, 2022

Comparison Summary

perrotta commented Nov 19, 2022

syuvivida commented Nov 19, 2022

cmsbuild commented Nov 20, 2022

francescobrivio commented Nov 20, 2022

francescobrivio commented Nov 20, 2022

cmsbuild commented Nov 21, 2022

Comparison Summary

emanueleusai commented Nov 21, 2022

cmsbuild commented Nov 21, 2022

perrotta commented Nov 22, 2022

francescobrivio commented Nov 18, 2022 •

edited

cmsbuild commented Nov 18, 2022 •

edited