Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt protection against zero weights or pt for SV producer [12_5_X] #40123

Merged
merged 1 commit into from Nov 24, 2022
Merged

Adapt protection against zero weights or pt for SV producer [12_5_X] #40123

merged 1 commit into from Nov 24, 2022

Conversation

AnnikaStein
Copy link
Contributor

@AnnikaStein AnnikaStein commented Nov 21, 2022

PR description:

This PR applies the same protective measures introduced in #40081 for another producer in the RecoBTag/SecondaryVertex package. While we have not seen a precedent case that yields the abort signal reported in #40032 coming from this particular producer (TemplatedSecondaryVertexProducer.cc), the logic is essentially same, so we think we should include the fixes here for safety purposes as well.

PR validation:

Tests have been performed for CMSSW_12_5_2_patch1 (https://cms-sw.github.io/PRWorkflow.html)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Meant for 12_5_X, as a backport of #40093 (we follow the same scheme for backports as for the BoostedDoubleSVProducer, just applied to TemplatedSecondaryVertexProducer to avoid abort signals in the future)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2022

A new Pull Request was created by @AnnikaStein (Annika Stein) for CMSSW_12_5_X.

It involves the following packages:

  • RecoBTag/SecondaryVertex (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

backport of #40093

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4c61a/29204/summary.html
COMMIT: ee30e5a
CMSSW: CMSSW_12_5_X_2022-11-22-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40123/29204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3734835
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c51a499 into cms-sw:CMSSW_12_5_X Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants