Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.5] Protection for negative kinetic energy in Geant4 tracking #40131

Merged
merged 1 commit into from Nov 24, 2022

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 22, 2022

PR description:

This PR should address the issue #40126 - tracking of a particle with very small negative kinetic energy. This issue should be rare, because never was reported below. The fix does not affect any physics.

PR validation:
private

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2022

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_12_5_X.

It involves the following packages:

  • SimG4Core/Application (simulation)
  • SimG4Core/SensitiveDetector (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Nov 22, 2022

type bug-fix

@civanch
Copy link
Contributor Author

civanch commented Nov 22, 2022

backport #40127

@civanch
Copy link
Contributor Author

civanch commented Nov 22, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f3eb5/29190/summary.html
COMMIT: 3645d85
CMSSW: CMSSW_12_5_X_2022-11-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40131/29190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3734847
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Nov 23, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da73a68 into cms-sw:CMSSW_12_5_X Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants