MTD validation: update monitoring of reconstructed clusters

[fabiocos]

PR description:

In order to support the validation of MTD cluster properties, which will be the topic of a next PR, several histograms so far optional and off by default are promoted as regular histograms to be monitored. At the same time, the large memory-consuming 2D occupancy plots are moved under the optional flag, since they are more useful for visual inspection in case of debugging than for quantitative comparisons.

PR validation:

The code runs smoothly on test wf. 20903.0 producing the desired output.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40143/33134

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@gsorrentino18 FYI

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fea080/29235/summary.html
COMMIT: cbd4461
CMSSW: CMSSW_12_6_X_2022-11-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40143/29235/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417179
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 86
• DQMHistoTests: Total successes: 3417062
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2709.0660000000003 KiB( 47 files compared)
• DQMHistoSizes: changed ( 20834.0,... ): -454.062 KiB MTD/ETL
• DQMHistoSizes: changed ( 20834.0,... ): 2.552 KiB MTD/BTL
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

thanks to @gsorrentino18 for noticing it, of course it does not change any conclusion/result

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40143/33136

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #40143 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fea080/29240/summary.html
COMMIT: 3f5319c
CMSSW: CMSSW_12_6_X_2022-11-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40143/29240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417179
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 87
• DQMHistoTests: Total successes: 3417062
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2709.07 KiB( 47 files compared)
• DQMHistoSizes: changed ( 20834.0,... ): -454.062 KiB MTD/ETL
• DQMHistoSizes: changed ( 20834.0,... ): 2.552 KiB MTD/BTL
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

@cms-sw/dqm-l2 any comment or question?

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1