Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clang fixes #4015

Merged
merged 4 commits into from May 28, 2014
Merged

More clang fixes #4015

merged 4 commits into from May 28, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented May 27, 2014

Same as #4004, just for 72X in case people do not want to have it in 71X for some reason.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_2_X.

More clang fixes

It involves the following packages:

CalibCalorimetry/EcalTPGTools
CondFormats/Serialization
DQM/HcalMonitorModule
DQMServices/Components
DataFormats/EcalDigi
DataFormats/PatCandidates
EventFilter/CSCRawToDigi
Geometry/CommonTopologies
JetMETCorrections/Type1MET
L1Trigger/GlobalTriggerAnalyzer
L1TriggerConfig/DTTPGConfigProducers
MuonAnalysis/MomentumScaleCalibration
PhysicsTools/FWLite
PhysicsTools/MVAComputer
PhysicsTools/MVATrainer
PhysicsTools/PatUtils
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelTriplets
RecoTracker/TkHitPairs
SimG4Core/GFlash
TauAnalysis/MCEmbeddingTools
TrackingTools/GeomPropagators
Validation/EventGenerator
Validation/RecoVertex

@diguida, @ianna, @thspeer, @rcastello, @bendavid, @civanch, @ojeda, @cmsbuild, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @ggovi, @vadler, @Degano, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @thuer, @monttj, @StoyanStoynev can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @GiacomoSguazzoni, @frmeier, @rovere, @argiro, @inugent, @nhanvtran, @gpetruc, @cerati, @mmusich, @lgray, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@apfeiffer1
Copy link
Contributor

+1

@diguida
Copy link
Contributor

diguida commented May 28, 2014

+1
Change sprintf into strcpy in CalibCalorimetry/EcalTPGTools/plugins/EcalTPGParamBuilder.cc, and a more coherent handling of a do...while loop in CondFormats/Serialization/interface/eos/portable_oarchive.hpp.

@slava77
Copy link
Contributor

slava77 commented May 28, 2014

+1

for #4015 6db6e1d
jenkins is OK

@nclopezo
David, any idea why only one diff is run with the fwlite script?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_2_X_2014-05-27-0200+4015/2684/validateJR/

@ktf
Copy link
Contributor Author

ktf commented May 28, 2014

Bypassing DQM. @deguio complain if not ok.

ktf added a commit that referenced this pull request May 28, 2014
@ktf ktf merged commit 6c21ec1 into cms-sw:CMSSW_7_2_X May 28, 2014
@ktf ktf deleted the more-clang-fixes branch June 16, 2014 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet