Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT meantimer tune #4018

Merged
merged 1 commit into from Jun 10, 2014
Merged

DT meantimer tune #4018

merged 1 commit into from Jun 10, 2014

Conversation

ptraczyk
Copy link
Contributor

A small tuning of MT reco following the enabling of realistic hit uncertainties. A very small but consistent improvement in chi2, resolution, efficiency etc in RelVals.
image
image

Due to tightened chi2 cuts in segment building the numbers of hits become lower, this is expected (quality improves and efficiency does not suffer):
image

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptraczyk (Piotr Traczyk) for CMSSW_7_2_X.

DT meantimer tune

It involves the following packages:

RecoLocalMuon/DTSegment

@nclopezo, @cmsbuild, @thspeer, @StoyanStoynev, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

testing

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

segment parameters are changing more substantially than the final muons:
here are some plots in muon gun pt10 (comparing with CMSSW_7_2_X_2014-05-29-1400)

all_sign383vsorig_singlemupt10wf20p0c_mindtchamberiddtrecsegment4dsownedrangemap_dt4dcosmicsegments__reco_obj_collection__data__chi2 99_99

all_sign383vsorig_singlemupt10wf20p0c_mindtchamberiddtrecsegment4dsownedrangemap_dt4dsegments__reco_obj_collection__data__chi2 99_99

The effect is even more visible for 1 TeV muon gun (with more radiation and now tighter cuts, segments are visibly shorter; this is not affecting final tracks that much)
all_sign383vsorig_singlemupt1000wf22p0c_dtchamberiddtrecsegment4dsownedrangemap_dt4dsegments__reco_obj_collection__data__degreesoffreedom

I guess, these are somewhat expected
.. more later

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

For muon guns (similar for background samples, less stats there though)

  • Track parameters don't change significantly
  • slightly better time at IP error (10 GeV sample plot below)
    wf20_timeatiperr
  • slightly worse theta residuals /pulls for track-segment matching (10 GeV muons below, red is new)
    wf20_dtst3dydz

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

+1

for #4018 bba55da
based on the review above: changes are somewhat in the right direction (not everything is improved)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2014

@ktf @nclopezo @Degano
Why is this still not merged?
Please check
Thanks

nclopezo added a commit that referenced this pull request Jun 10, 2014
RecoLocalMuon/DTSegment -- DT meantimer tune
@nclopezo nclopezo merged commit 3c70a21 into cms-sw:CMSSW_7_2_X Jun 10, 2014
@ptraczyk ptraczyk deleted the DTmeantimerTune branch September 9, 2014 09:53
@slava77 slava77 mentioned this pull request Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants