Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALCA-DB] [LLVM14] Apply code checks #40200

Merged
merged 1 commit into from Nov 30, 2022
Merged

[ALCA-DB] [LLVM14] Apply code checks #40200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CondCore/PopCon/interface/PopCon.h
View file
Open in desktop
Expand Up @@ -96,7 +96,7 @@ namespace popcon {
s << "PopCon v" << s_version << "; " << msg << ret.second;
m_dbService->setLogHeaderForRecord(m_record, source.id(), s.str());
}
for (auto it : iovs)
for (const auto& it : iovs)
edm::LogInfo("PopCon") << "Since " << it.first << std::endl;

m_dbService->writeMany(iovs, m_record);
Expand Down
8 changes: 4 additions & 4 deletions CondFormats/DTObjects/src/DTReadOutMapping.cc
View file
Open in desktop
Expand Up @@ -222,7 +222,7 @@ int DTReadOutMapping::geometryToReadOut(int wheelId,
searchStatus = atomicCache()->grROB.find(cellKey.begin(), cellKey.end(), robMLgr);
if (searchStatus)
return searchStatus;
if (!(robMLgr->size()))
if (robMLgr->empty())
return 1;
std::vector<int>::const_iterator tdc_iter = robMLgr->begin();
std::vector<int>::const_iterator tdc_iend = robMLgr->end();
Expand All @@ -239,7 +239,7 @@ int DTReadOutMapping::geometryToReadOut(int wheelId,
searchStatus = atomicCache()->grROS.find(cellKey.begin(), cellKey.end(), rosMLgr);
if (searchStatus)
continue;
if (!(rosMLgr->size()))
if (rosMLgr->empty())
continue;
std::vector<int>::const_iterator ros_iter = rosMLgr->begin();
std::vector<int>::const_iterator ros_iend = rosMLgr->end();
Expand All @@ -262,11 +262,11 @@ int DTReadOutMapping::geometryToReadOut(int wheelId,
searchStatus = atomicCache()->grDDU.find(cellKey.begin(), cellKey.end(), dduMLgr);
if (searchStatus)
continue;
if (!(dduMLgr->size()))
if (dduMLgr->empty())
continue;
if (searchStatus)
return searchStatus;
if (!(dduMLgr->size()))
if (dduMLgr->empty())
return 1;
loop0++;
std::vector<int>::const_iterator ddu_iter = dduMLgr->begin();
Expand Down