HCAL: Modifications to the LUT validation script

[Michael-Krohn]

PR description:

Modifications to the HCAL LUTs validation script that explicitly check and report whether the fine grain bits in the HCAL LUTs are changing. This is to assure that we know if the fine grain bits are changing when creating a new LUT

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

This PR is not a backport. This PR updates the "service" scripts for LUTs generation and validation

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40228/33271

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40228/33271/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40228/33271/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40228/33273

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

• CaloOnlineTools/HcalOnlineDb (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70911/29432/summary.html
COMMIT: 0c5439b
CMSSW: CMSSW_13_0_X_2022-12-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40228/29432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421159
• DQMHistoTests: Total failures: 158
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

Hmm I see a lot of failures in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_0_X_2022-12-02-1100+e70911/54493/11634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/

for tracking and strips.. that cannot come from this PR, right?

[tvami]

+db

• some differences, that must actually come from another PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1