New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron MVA-based ID for Run3 from EGamma POG #40230
Merged
cmsbuild
merged 12 commits into
cms-sw:master
from
Prasant1993:EGMRun3MVAID_from-CMSSW_13_0_X_2022-11-29-2300
Dec 8, 2022
+459
−36
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
94b02d8
Run3 MVA electron ID changes
Prasant1993 ecc5886
Changes implemented to test Run3 electron MVA ID
Prasant1993 3fbdad6
Added some changes
Prasant1993 7726f03
Cut values for new model files
Prasant1993 3b8a440
final electron MVA retrained model files
Prasant1993 95a2348
make treatment of Run2 and Run2 more consistent for electron and phot…
swertz baa7cdb
propagate to nanoDQM
swertz f388fb5
make sure electron scale/smearing are only for Run2
swertz bb5b9c8
path of weight files added from cms-data
Prasant1993 e7b0d8d
Run3 IDs not to be stored in Run2
Prasant1993 a4cbc7e
Fixed the additional space issue
Prasant1993 cbe51f7
Missing mvanoIso ID required for electronMVATTH in Run2
Prasant1993 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
RecoEgamma/ElectronIdentification/data/ElectronIDVariablesRun3.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# File: ElectronIDVariablesRun3.txt | ||
# | ||
# This file is to be read by the MVAVariableHelper class. Lists all the | ||
# variables which appear in the xml files for the MVA based Electron IDs for Run2. | ||
# Variables are given line by line. The columns of each entry correspond to: | ||
# | ||
# 1. The name under which the variable appears in the weight files. | ||
# 2. How to get this variable from the electron with the cut parser (NO SPACES!) | ||
# or if not available, how to get the variables elsewhere. | ||
# 3. The lower clip value for the variable to avoid crazy values. "None" if no clip. | ||
# 4. The upper clip value. | ||
# | ||
|
||
# This selection of ID variables is rather large and not intended to be used by a real ID, | ||
# but by an ntuplizer which dumps all possible ID variables. | ||
|
||
rho fixedGridRhoFastjetAll None None | ||
ele_oldsigmaietaieta full5x5_sigmaIetaIeta None None | ||
ele_oldsigmaiphiiphi full5x5_sigmaIphiIphi None None | ||
ele_oldcircularity 1.-full5x5_e1x5/full5x5_e5x5 -1. 2. | ||
ele_oldr9 full5x5_r9 None 5. | ||
ele_scletawidth superCluster.etaWidth None None | ||
ele_sclphiwidth superCluster.phiWidth None None | ||
ele_oldhe full5x5_hcalOverEcal None None | ||
ele_kfhits closestCtfTrackNLayers None None | ||
ele_kfchi2 closestCtfTrackNormChi2 None 10. | ||
ele_gsfchi2 gsfTrack.normalizedChi2 None 200. | ||
ele_fbrem fbrem -1. None | ||
ele_gsfhits gsfTrack.hitPattern.trackerLayersWithMeasurement None None | ||
ele_expected_inner_hits gsfTrack.hitPattern.numberOfLostHits('MISSING_INNER_HITS') None None | ||
ele_conversionVertexFitProbability convVtxFitProb None None | ||
ele_ep eSuperClusterOverP None 20. | ||
ele_eelepout eEleClusterOverPout None 20. | ||
ele_IoEmIop 1.0/ecalEnergy-1.0/trackMomentumAtVtx.R None None | ||
ele_deltaetain abs(deltaEtaSuperClusterTrackAtVtx) -0.06 0.06 | ||
ele_deltaphiin abs(deltaPhiSuperClusterTrackAtVtx) -0.6 0.6 | ||
ele_deltaetaseed abs(deltaEtaSeedClusterTrackAtCalo) -0.2 0.2 | ||
ele_psEoverEraw superCluster.preshowerEnergy/superCluster.rawEnergy None None | ||
ele_pfPhotonIso pfIsolationVariables.sumPhotonEt None None | ||
ele_pfChargedHadIso pfIsolationVariables.sumChargedHadronPt None None | ||
ele_pfNeutralHadIso pfIsolationVariables.sumNeutralHadronEt None None | ||
ele_ecalPFClusterIso ecalPFClusterIso None None | ||
ele_hcalPFClusterIso hcalPFClusterIso None None | ||
ele_dr03TkSumPt dr03TkSumPt None None |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prasant1993 remove this extra space you have added. Looks like this is what caused the test to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-kapoor, thanks for spotting the additional space issue present. Fixed it now.