Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT-specific MC GT for frozen "V1.4" HLT menu to "postEE" scenario [12_4_X only] #40233

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Dec 3, 2022

PR description:

This PR is specific to the 12_4_X release cycle.

It updates the HLT-specific MC GT for the frozen "V1.4" pp menu to the auto:phase1_2022_realistic_postEE GT introduced in #39019.

This change does not affect any workflow (not in PR tests, nor in IBs). It is done mainly to have in autoCondHLT the same GT that will be used with this HLT menu in central MC production (i.e. Run3Summer22EE campaign), see CMSHLT-2524.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/HLT (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Dec 3, 2022

please test

The tests are pointless in this case, but a signature would trigger them in any case.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0423bf/29445/summary.html
COMMIT: 8f4bd4c
CMSSW: CMSSW_12_4_X_2022-12-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40233/29445/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3709276
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Dec 3, 2022

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

missirol commented Dec 6, 2022

@cms-sw/orp-l2 , kind ping to review this PR.

@rappoccio
Copy link
Contributor

@missirol I'm not sure I'm seeing the master PR, I'm assuming that should also be there?

@missirol
Copy link
Contributor Author

missirol commented Dec 6, 2022

Hi @rappoccio , no, this is only for 12_4_X , because the "postEE" HLT menu is only there (I tried to explain in the description).

@rappoccio
Copy link
Contributor

+1

Will not go to 13_0.

@cmsbuild cmsbuild merged commit 55e651d into cms-sw:CMSSW_12_4_X Dec 6, 2022
@missirol missirol deleted the autoCondHLT_MC_v1p4postEE_124X branch December 6, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants