Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change of vertex smearing for 2022 HI , 2023 and 2024 relvals #40238

Merged
merged 1 commit into from Dec 6, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 5, 2022

PR description:

title says it all, address #39019 (comment)

PR validation:

none.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2022

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-240f7a/29459/summary.html
COMMIT: f61179a
CMSSW: CMSSW_12_4_X_2022-12-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40238/29459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3189 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 8701
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3700582
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2022

Now as expected the transverse impact parameter w.r.t beamspot makes sense again in wf 12434.0

Screenshot from 2022-12-05 17-05-45

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2022

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 please have a look urgently, this is needed to restore the consistency of the >= 2022 relvals.

@srimanob
Copy link
Contributor

srimanob commented Dec 5, 2022

+Upgrade

@kskovpen
Copy link
Contributor

kskovpen commented Dec 5, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Dec 6, 2022

@cms-sw/orp-l2 please clarify the intentions on this PR, which is a mandatory bug-fix.

@rappoccio
Copy link
Contributor

@mmusich should there be a master branch version of this PR? I don't see it.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 6, 2022

@rappoccio

should there be a master branch version of this PR? I don't see it.

no, this fixes a mistake that was done exclusively in this branch, see please discussion at #39019 (comment)

@rappoccio
Copy link
Contributor

+1

Fixing bug in one branch only.

@cmsbuild cmsbuild merged commit 34dbdf2 into cms-sw:CMSSW_12_4_X Dec 6, 2022
@mmusich mmusich deleted the fix_relval_post_39019 branch December 6, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants