New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead assignments and clean up a bit GenFilters #40287
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40287/33340
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours.
Comparison SummarySummary:
|
@cms-sw/generators-l2 relval inputs timed out is not an issue that should need waste resouces by retriggering the tests: please evaluate this PR as if the tests were passed |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8d88/29672/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 is there anything that prevents you reviewing this PR? Could you please comment in any case, telling what you are waiting for, or when do you plan to review? |
+1 |
sorry, i missed this pr |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Remove dead assignments pointed out by the SA
Further sparse cleaning of the two touched files.
PR validation:
It builds
No changes expected whatsoever