Update to include the timing reco through weights

[BiancaPinolini]

PR description:

The necessary files to implement the timing reconstruction for Ecal-Phase2 through the weights method have been added.

Here you can find the link to the presentation of the MoCa meeting of the 16th November 2022.

[cmsbuild]

@BiancaPinolini, CMSSW_13_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40291/33348

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @BiancaPinolini (Bianca Sofia Pinolini) for master.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rchatter, @argiro, @missirol, @thomreis, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[thomreis]

type ecal

[thomreis]

Hi @BiancaPinolini could you please add a link to your presentation in the last ECAL DPG meeting for reference.

[thomreis]

please test workflow 39434.61

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8d491/29573/summary.html
COMMIT: 04f8677
CMSSW: CMSSW_13_0_X_2022-12-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40291/29573/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 39434.61

[BiancaPinolini]

Hi @BiancaPinolini could you please add a link to your presentation in the last ECAL DPG meeting for reference.

Here you can find the link to the presentation of the MoCa meeting of the 16th november, 2022.

[thomreis]

Hi @BiancaPinolini could you please add a link to your presentation in the last ECAL DPG meeting for reference.

Here you can find the link to the presentation of the MoCa meeting of the 16th november, 2022.

Can you please put in it the PR description on the top? In order to find if back easily.

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8d491/29580/summary.html
COMMIT: 04f8677
CMSSW: CMSSW_13_0_X_2022-12-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40291/29580/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 29 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421510
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[thomreis]

Hi @cms-sw/reconstruction-l2 in order to test this module a workflow with the .61 suffix should be used. I have tried to select 39434.61 in the test parameters but cmsbuild says that this is an undefined workflow. How can this be done?

[clacaputo]

39434.61

Hi @thomreis , I'm not able to find it also if I run runTheMatrix.py --what cleanedupgrade -nel 39434.61 on lxplus in 13_0_0_pre1. Consider that there was a remaining of the upgrade WFs #39571, although I can't see 39434.61 among the list of the renamed ones.

[thomreis]

Hi @clacaputo thanks for checking. I had been looking if the WF existed with 12_6_0_pre3 but it seems to have indeed been renamed twice since.

[thomreis]

test parameters:

• workflow = 20034.61
• relvals_opt = --what cleanedupgrade

[thomreis]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8d491/29696/summary.html
COMMIT: 04f8677
CMSSW: CMSSW_13_0_X_2022-12-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40291/29696/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 20034.61

----- Begin Fatal Exception 19-Dec-2022 20:32:23 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'pathALCARECOMuAlOverlapsGeneralTracks'
   [2] Calling method for module AlignmentTrackSelectorModule/'ALCARECOMuAlOverlapsGeneralTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: generalTracks
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

[thomreis]

This error is not related to the PR. It appears that the WF is broken already in vanilla 13_0_0_pre2.
Previously the .61 WFs did not have a step5. What needs to be done to get this to work?

[thomreis]

please test with #40378

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8d491/29728/summary.html
COMMIT: 04f8677
CMSSW: CMSSW_13_0_X_2022-12-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40291/29728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20034.61 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 31 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3558162
• DQMHistoTests: Total failures: 1194
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556946
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 165 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[thomreis]

This PR itself does not require #40378 . It is only required to fix the test workflow, that is otherwise broken in master.

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1