Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic SiStripApproximateCluster Monitoring #40295

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 12, 2022

PR description:

Title says it all. Provide a new package in order to be able to monitor both online and offline the SiStripApproximateCluster collection and created the necessary modifications to be able to run it in the offline DQM by usage of the approxSiStripClusters process modifier and in the SiStrip Online DQM client.

PR validation:

Run successfully runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos and obtained plots, both with the compareClusters parameter set to True or False.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport is needed

@mmusich
Copy link
Contributor Author

mmusich commented Dec 12, 2022

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33368

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/SiStripMonitorApproximateCluster (****)
  • DQM/SiStripMonitorClient (dqm)

The following packages do not have a category, yet:

DQM/SiStripMonitorApproximateCluster
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @batinkov, @hdelanno, @battibass, @sroychow, @fioriNTU, @jandrea, @idebruyn, @venturia, @threus, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 12, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daabb7/29583/summary.html
COMMIT: 5131af7
CMSSW: CMSSW_13_0_X_2022-12-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40295/29583/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421510
  • DQMHistoTests: Total failures: 1194
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420294
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33375

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33393

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40295 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 14, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daabb7/29618/summary.html
COMMIT: 6f4ca8b
CMSSW: CMSSW_13_0_X_2022-12-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40295/29618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3619026
  • DQMHistoTests: Total failures: 1191
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3617813
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 33.712 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 140.58 ): 30.051 KiB SiStripApproximateClusters/clusterBarycenter
  • DQMHistoSizes: changed ( 140.58 ): 2.003 KiB SiStripApproximateClusters/numberOfClusters
  • DQMHistoSizes: changed ( 140.58 ): 1.050 KiB SiStripApproximateClusters/clusterAvgCharge
  • DQMHistoSizes: changed ( 140.58 ): 0.546 KiB SiStripApproximateClusters/clusterWidth
  • DQMHistoSizes: changed ( 140.58 ): 0.062 KiB SiStripApproximateClusters/clusterSaturation
  • Checked 215 log files, 164 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 14, 2022

@cms-sw/dqm-l2 sorry for multiple pushes. Should be ready for review now.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2022

type trk

@cmsbuild cmsbuild added the trk label Dec 15, 2022
@emanueleusai
Copy link
Member

+1

  • spurious DQM differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Changes in DQM unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants