-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic SiStripApproximateCluster
Monitoring
#40295
Conversation
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33368
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
The following packages do not have a category, yet: DQM/SiStripMonitorApproximateCluster @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daabb7/29583/summary.html Comparison SummarySummary:
|
5131af7
to
b66c891
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33375
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40295/33393
|
Pull request #40295 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daabb7/29618/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 sorry for multiple pushes. Should be ready for review now. |
type trk |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Changes in DQM unrelated to this PR. |
PR description:
Title says it all. Provide a new package in order to be able to monitor both online and offline the
SiStripApproximateCluster
collection and created the necessary modifications to be able to run it in the offline DQM by usage of theapproxSiStripClusters
process modifier and in the SiStrip Online DQM client.PR validation:
Run successfully
runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos
and obtained plots, both with thecompareClusters
parameter set toTrue
orFalse
.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, no backport is needed