Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files from CalibTracker/SiStripDCS to cms-data #40330

Merged
merged 1 commit into from Dec 17, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Dec 15, 2022

PR description:

I came across this webpage
https://cmssdt.cern.ch/SDT/cgi-bin/newQA.py?arch=el8_amd64_gcc10&release=CMSSW_13_0_X_2022-12-14-2300
which shows that
https://github.com/cms-sw/cmssw/tree/master/CalibTracker/SiStripDCS/data
this is the 6 biggest directory in CMSSW. The PR moves the files out of CMSSW to cms-data

PR validation:

O2O tests to be performed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed

@tvami
Copy link
Contributor Author

tvami commented Dec 15, 2022

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40330/33415

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CalibTracker/SiStripDCS (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Dec 15, 2022

@cmsbuild , please test

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2022

test parameters:

@tvami
Copy link
Contributor Author

tvami commented Dec 15, 2022

test parameters:

@tvami
Copy link
Contributor Author

tvami commented Dec 15, 2022

@cmsbuild , please abort

@tvami
Copy link
Contributor Author

tvami commented Dec 15, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a778/29640/summary.html
COMMIT: 8b295ea
CMSSW: CMSSW_13_0_X_2022-12-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40330/29640/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a778/29640/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a778/29640/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 156 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557425
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Dec 16, 2022

+alca

  • unit test testing O2O passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e7d6115 into cms-sw:master Dec 17, 2022
@mmusich mmusich deleted the moveCalibTrackerSiStripDCStoCMSDATA branch December 17, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants