Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for intermediate resonance particles [10_6_X] #40309

Merged
merged 1 commit into from Dec 15, 2022

Conversation

jieunyoo
Copy link
Contributor

Attempt to backport this request to 10_6_X
This is from PR # #40254

add filter for intermediate resonance particles
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2022

A new Pull Request was created by @jieunyoo (jieun) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

This is highly badly coordinated. We have just built a 10_6_31_patch1 release, and I don't think we will be able to build another 10_6_X patch release in the coming days, due to more urgent requests queued.
Please @cms-sw/generators-l2 collect all requests from your group, and come to the ORP meeting with them.
I would suggest that starting from now whatever is not requested at the ORP is not dealt with by the release managers.

@jieunyoo
Copy link
Contributor Author

Hi @perrotta . Thanks for the comment. It would be ok for the 10_6_X_patch release. Sorry for the trouble. I’m not familiar with this workflow. Is there a generators meeting I should go to to get this approved? Basically I want to get a UL sample made with this filter. What are the best and quickest ways to go about this since we need this signal sample for my thesis work. Without this filter, we would need say 10 million samples of the same thing requested, and that seems inefficient and I don’t know if it would be approved since it’s so large, so I was working on this filter. Thanks !

@perrotta
Copy link
Contributor

please test

@perrotta perrotta changed the title Backport of #40254, gen filter Add filter for intermediate resonance particles [10_6_X] Dec 13, 2022
@perrotta
Copy link
Contributor

backport of #40254

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caf18e/29609/summary.html
COMMIT: f9f8101
CMSSW: CMSSW_10_6_X_2022-12-11-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40309/29609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

This is highly badly coordinated. We have just built a 10_6_31_patch1 release, and I don't think we will be able to build another 10_6_X patch release in the coming days, due to more urgent requests queued. Please @cms-sw/generators-l2 collect all requests from your group, and come to the ORP meeting with them. I would suggest that starting from now whatever is not requested at the ORP is not dealt with by the release managers.

@perrotta sorry for the inconvenience, we'll follow your suggestion.

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7326ee4 into cms-sw:CMSSW_10_6_X Dec 15, 2022
@perrotta
Copy link
Contributor

@jieunyoo please prepare similar backports for 12_4_X (for 2022 analyses) and 12_6_X

jieunyoo added a commit to jieunyoo/genproductions that referenced this pull request Dec 16, 2022
@Saptaparna
Copy link
Contributor

Hi @perrotta yes, we were not notified in advance. Usually we would have had a presentation from the requester in the GEN meeting. In fact, yesterday I had a chat with the requester and pointed to an alternate way to generate samples instead of integrating this PR in the release. @jieunyoo just because the PR is merged doesn't mean that a new release will be available for your sample submission. The UL campaign has been operational for 2+ years, so why is this request being made now. Also, please request presentations in the GEN meeting in advance, so we have an idea of what to bring to Andrea and Sal's attention at the ORP meeting. There is a structure in place and bypassing the structure takes everyone by surprise.

@jieunyoo
Copy link
Contributor Author

Hi. Thanks for the reply. Sure, I did not know about the workflow. I will definitely bring this up in the generators meeting. Could you please let me know which meeting I need to attend and add my name? I will send you an email as well requesting this.
We just decided on my thesis topic this past September 2022. So that is why this request is being made now. I researched different ways to make a cut on the pT. My MC contact suggested at first to make a cut on bornktmin in the card, however after research and speaking with a Powheg author, we found out that is not the correct way. Determining this took time. Also, it took time to figure out that we could make such a filter. It also took time to find out that we would need a specific CMSSW pull request made in order to use this filter and ask for a sample to be made. I provided a custom CMSSW tar package to my MC contact, but we found out later that MCM can not take that.
So in conclusion there is currently no filter available for this. The only CMSSW filter available for a cut on pT is available for final state partons; none is available for intermediate resonances.
The alternative way to get this is to do private production of samples which takes time. I would like to request a MC production (going later through the MC channels) and the only way to request it officially is to get this in CMSSW since MC contacts don't deal with this.
If we do not have this filter, then in order to get enough statistics for the high pT region, we will need 10 times more samples. To not waste computational time, we hope to have this filter in CMSSW.
Are there plans for another to be made available @perrotta? What would be the timeline? I'm sure that there will be other fixes by other analysts for CMSSW_10_6_X since all UL analyses need to use this. I think this filter will also be useful for any other analysts who are doing an UL analysis on boosted topologies, and as I see it now, many boosted analyses are in the works. My apologies if my timing was bad in requesting this. This is my first time editing CMSSW. Also, I wasn't aware of these different release cycles or deadlines, but now I'm subscribed to your CMSTalk channel and will follow them and know better next time. Thank you!

@Saptaparna
Copy link
Contributor

@jieunyoo I understand. You are more than welcome to present your work and plans with timeline at GEN meeting on Monday (the meeting starts at 14:00 CERN and I will send you the coordinates via email).

@Saptaparna
Copy link
Contributor

@perrotta and @rappoccio Would it be possible for us to create a new release with this PR so the analysts can request samples? thanks! :)

@perrotta
Copy link
Contributor

perrotta commented Feb 2, 2023

@perrotta and @rappoccio Would it be possible for us to create a new release with this PR so the analysts can request samples? thanks! :)

@Saptaparna the release is there, see https://cms-talk.web.cern.ch/t/production-release-cmssw-10-6-32-now-available/19939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants