New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can now run multiple OscarMTProducers in the same job #40316
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40316/33397
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
}); //suspend | ||
}); //group.run | ||
FinalWaitingTask last{group}; | ||
group.run([&]() { iFunc(WaitingTaskHolder(group, &last)); }); //group.run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to include the contents of #40253. Could these be removed? Then the core
signature would not be needed.
This was needed to test generating GEN+SIM in mixing module to generate pileup on the fly.
13c342e
to
d9d647d
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40316/33399
|
Pull request #40316 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-584adf/29658/summary.html Comparison SummarySummary:
|
Comparison differences are in 11634.7 and thus spurious (#39803). |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This was needed to test generating GEN+SIM in mixing module to generate pileup on the fly. The problem is Geant4 requires that it be initialized on one and only one thread which means all instances of OscarMTProducer must share that thread.
PR validation:
Code compiles. Test of on-the-fly pileup succeeded.