Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Geant4 physics configuration #40345

Merged
merged 1 commit into from Dec 17, 2022
Merged

Fix Geant4 physics configuration #40345

merged 1 commit into from Dec 17, 2022

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Dec 16, 2022

PR description:

The IB with Geant4 11.1 was broken, G4TransportWithMSC is now an int. Also move the configuration options for PhotoeffectBelowKShell and G4TransportWithMSC to ParametrisedEMPhysics, where it was before.

PR validation:

builds and works for G4VECGEOM IB; no backport needed, but urgent for the next G4VECGEOM IB.

The IB with Geant4 11.1 was broken, G4TransportWithMSC is now an int.
Also move the configuration options for PhotoeffectBelowKShell and
G4TransportWithMSC to ParametrisedEMPhysics, where it was before.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40345/33434

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hahnjo (Jonas Hahnfeld) for master.

It involves the following packages:

  • SimG4Core/Application (simulation)
  • SimG4Core/PhysicsLists (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Dec 16, 2022

please test

@civanch
Copy link
Contributor

civanch commented Dec 16, 2022

FYI @bsunanda

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21d779/29662/summary.html
COMMIT: ea64957
CMSSW: CMSSW_13_0_X_2022-12-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40345/29662/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 1191
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556308
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Dec 17, 2022

+1

regression problems do not related to this PR - it is instability in MkFit WF.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

please test for CMSSW_13_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21d779/29671/summary.html
COMMIT: ea64957
CMSSW: CMSSW_13_0_G4VECGEOM_X_2022-12-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40345/29671/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_G4VECGEOM_X_2022-12-15-2300/src/SimG4Core/Application/plugins/OscarMTProducer.cc
>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_G4VECGEOM_X_2022-12-15-2300/src/SimG4Core/Application/plugins/OscarMTProducer.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/SimG4Core/Application/plugins/SimG4CoreApplicationPlugins/libSimG4CoreApplicationPlugins.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02763/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lSimG4CoreApplication
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02763/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lSimG4CoreCustomPhysics
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/SimG4Core/Application/plugins/SimG4CoreApplicationPlugins/libSimG4CoreApplicationPlugins.so] Error 1
Leaving library rule at src/SimG4Core/Application/plugins
>> Building  big object file tmp/el8_amd64_gcc11/src/SimG4Core/Application/plugins/SimG4CoreApplicationPlugins/bigobj/SimG4CoreApplicationPlugins.obj
Entering library rule at SimG4Core/Application
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_G4VECGEOM_X_2022-12-15-2300/src/SimG4Core/Application/src/CMSGDMLWriteStructure.cc


@perrotta
Copy link
Contributor

+1

  • Compilation errors have disappearead from SimG4Core/PhysicsLists in the G4VECGEOM build

@cmsbuild cmsbuild merged commit ce0c80c into cms-sw:master Dec 17, 2022
@hahnjo hahnjo deleted the fix-g4SimHits branch February 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants