Delete commented out imports of deprecated JetCorrector cffs #40348

wddgit · 2022-12-16T16:23:02Z

PR description:

We just removed central cff files related to deprecated JetCorrector's (#39953). This PR removes lines of Python configuration code where those files were imported and those particular lines were already commented out.

@vlimant suggested we do this centrally in Issue #40304. Easy to do, so I just did it.

PR validation:

Only deletes comment lines.

We just removed central cff files related to deprecated JetCorrector's. This PR removes lines where those files were imported and those lines already commented out.

cmsbuild · 2022-12-16T16:29:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40348/33437

This PR adds an extra 28KB to repository

cmsbuild · 2022-12-16T16:29:58Z

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

L1Trigger/L1TNtuples (l1)
PhysicsTools/PatAlgos (xpog, reconstruction)
PhysicsTools/TagAndProbe (analysis)
Validation/RecoJets (dqm)

@swertz, @vlimant, @epalencia, @micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @Martin-Grunewald, @thomreis, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @kreczko, @jdolen, @ahinzmann, @missirol, @azotz, @eyigitba, @jdamgov, @gpetruc, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @dinyar, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

wddgit · 2022-12-16T16:52:35Z

please test

cmsbuild · 2022-12-16T20:48:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de819/29661/summary.html
COMMIT: 64b4a41
CMSSW: CMSSW_13_0_X_2022-12-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40348/29661/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3557521
DQMHistoTests: Total failures: 1188
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3556311
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

vlimant · 2022-12-16T21:36:10Z

+1

perrotta · 2022-12-17T08:31:00Z

PhysicsTools/TagAndProbe/test/Electron_TagProbeTreeProducer_cfg.py

@@ -389,7 +389,6 @@
 ##   |_____/_/\_\\__\___|_|  |_| |_|\__,_|_|    \_/ \__,_|_|  |___/
 ##   
 ## Here we show how to use a module to compute an external variable
-## process.load("JetMETCorrections.Configuration.DefaultJEC_cff")
 ## ak5PFResidual.useCondDB = False


This modifies a module from the line removed, can also get removed

Done. Thanks.

perrotta · 2022-12-17T08:33:17Z

L1Trigger/L1TNtuples/test/test_JetRecoProducer.py


 # get corrected jets


Suggested change

# get corrected jets

Also this comment can now get removed

Done. Thanks.

perrotta · 2022-12-17T08:34:11Z

Validation/RecoJets/python/JetValidation_cff.py

@@ -18,7 +18,6 @@
    newAk4CaloL2L3Corrector
 )

-#from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import ak7CaloL2L3,ak7CaloL2Relative,ak7CaloL3Absolute
 #newAk7CaloL2L3 = ak7CaloL2L3.clone()


Suggested change

#newAk7CaloL2L3 = ak7CaloL2L3.clone()

Done. Thanks.

perrotta · 2022-12-17T08:34:34Z

Validation/RecoJets/python/JetValidation_cff.py

@@ -29,7 +28,6 @@
    newAk4PFL1FastL2L3Corrector
 )

-#from JetMETCorrections.Configuration.JetCorrectionServices_cff import ak4JPTL1FastL2L3,ak4JPTL1Fastjet,ak4JPTL2Relative,ak4JPTL3Absolute
 #newAk4JPTL1FastL2L3 = ak4JPTL1FastL2L3.clone()


Suggested change

#newAk4JPTL1FastL2L3 = ak4JPTL1FastL2L3.clone()

Done. Thanks.

cmsbuild · 2022-12-19T15:37:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40348/33460

This PR adds an extra 28KB to repository

cmsbuild · 2022-12-19T15:37:38Z

Pull request #40348 was updated. @swertz, @vlimant, @epalencia, @micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @cecilecaillol, @rvenditti can you please check and sign again.

wddgit · 2022-12-19T15:38:47Z

please test

Made all changes requested in comments, deleted more unneeded comment lines.

cmsbuild · 2022-12-19T19:38:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de819/29693/summary.html
COMMIT: 9d93f8f
CMSSW: CMSSW_13_0_X_2022-12-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40348/29693/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555723
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2022-12-21T09:52:27Z

+1

This PR just removed some obsolete and already commented out lines: let merge it as such, to clean up the queue
I hope that @cms-sw/dqm-l2 @cms-sw/l1-l2 @cms-sw/reconstruction-l2 @cms-sw/xpog-l2 have nothing in contrary: otherwise just speak up

perrotta · 2022-12-21T09:52:58Z

merge

mandrenguyen · 2022-12-21T10:47:22Z

+1

emanueleusai · 2023-01-07T03:16:15Z

+1

Delete commented out imports of deprecated JetCorrector cffs

64b4a41

We just removed central cff files related to deprecated JetCorrector's. This PR removes lines where those files were imported and those lines already commented out.

cmsbuild added this to the CMSSW_13_0_X milestone Dec 16, 2022

cmsbuild added analysis-pending code-checks-pending dqm-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Dec 16, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2022

wddgit mentioned this pull request Dec 16, 2022

Deleting or migrating configuration files using the deprecated JetCorrector class #40304

Open

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2022

cmsbuild added xpog-approved and removed xpog-pending labels Dec 16, 2022

perrotta reviewed Dec 17, 2022

View reviewed changes

Delete more unneeded comment lines

9d93f8f

cmsbuild removed tests-approved code-checks-approved xpog-approved labels Dec 19, 2022

cmsbuild added code-checks-pending tests-pending xpog-pending labels Dec 19, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 19, 2022

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2022

cmsbuild added orp-approved and removed orp-pending labels Dec 21, 2022

cmsbuild merged commit a8b2c3a into cms-sw:master Dec 21, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 21, 2022

cmsbuild added dqm-approved and removed dqm-pending labels Jan 7, 2023

wddgit deleted the deleteDeprecatedComments branch January 13, 2023 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete commented out imports of deprecated JetCorrector cffs #40348

Delete commented out imports of deprecated JetCorrector cffs #40348

wddgit commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

wddgit commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

vlimant commented Dec 16, 2022

perrotta Dec 17, 2022

wddgit Dec 19, 2022

perrotta Dec 17, 2022

wddgit Dec 19, 2022

perrotta Dec 17, 2022

wddgit Dec 19, 2022

perrotta Dec 17, 2022

wddgit Dec 19, 2022

cmsbuild commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

wddgit commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

perrotta commented Dec 21, 2022

perrotta commented Dec 21, 2022

mandrenguyen commented Dec 21, 2022

emanueleusai commented Jan 7, 2023

Delete commented out imports of deprecated JetCorrector cffs #40348

Delete commented out imports of deprecated JetCorrector cffs #40348

Conversation

wddgit commented Dec 16, 2022

PR description:

PR validation:

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

wddgit commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

Comparison Summary

vlimant commented Dec 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

wddgit commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

Comparison Summary

perrotta commented Dec 21, 2022

perrotta commented Dec 21, 2022

mandrenguyen commented Dec 21, 2022

emanueleusai commented Jan 7, 2023