[126X] Save iEta/iPhi & iX/iY indices of ECAL crystals in nanoAOD

[swagata87]

Backport of #40327
Needed for upcoming 12_6_X renano, so that users can veto EE+ leak region with some margin using seed iX, iY indices.

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_6_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Save iEta/iPhi & iX/iY indices of ECAL crystals in nanoAOD #40327

[swagata87]

enable nano

[swagata87]

@cmsbuild please test

[swagata87]

type egamma

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d7984/29673/summary.html
COMMIT: 1543800
CMSSW: CMSSW_12_6_X_2022-12-17-1100/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40356/29673/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3458569
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3458538
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 96.95000000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 11.826 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 7.084 KiB Physics/NanoAODDQM
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 15294
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 15294
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 141.85399999999998 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.311,... ): 11.826 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.331,... ): 7.084 KiB Physics/NanoAODDQM
• Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.209	2.200	0.008 ( +0.4% )	9.18	9.16	+0.2%	1.570	1.506
2500.311	2.331	2.322	0.009 ( +0.4% )	8.92	8.85	+0.8%	1.934	1.873
2500.312	2.284	2.276	0.008 ( +0.3% )	8.97	8.99	-0.3%	1.925	1.866
2500.33	1.096	1.089	0.007 ( +0.6% )	21.51	21.90	-1.8%	1.699	1.700
2500.331	1.396	1.388	0.008 ( +0.6% )	15.64	15.90	-1.7%	1.842	1.840
2500.332	1.328	1.319	0.008 ( +0.6% )	17.71	17.58	+0.7%	1.802	1.798
2500.4	2.097	2.097	0.000 ( +0.0% )	9.79	9.80	-0.0%	1.449	1.406
2500.401	2.164	2.155	0.009 ( +0.4% )	9.85	9.81	+0.4%	1.250	1.203
2500.5	1.668	1.668	0.000 ( +0.0% )	15.35	15.53	-1.2%	1.170	1.112
2500.501	1.729	1.721	0.009 ( +0.5% )	15.32	15.57	-1.6%	1.168	1.125
2500.51	1.071	1.071	0.000 ( +0.0% )	28.42	28.27	+0.5%	1.460	1.407
2500.511	1.137	1.129	0.007 ( +0.6% )	27.69	28.09	-1.4%	1.483	1.436
2500.6	2.006	2.006	0.000 ( +0.0% )	12.61	12.53	+0.7%	1.224	1.171
2500.601	2.076	2.068	0.007 ( +0.3% )	12.45	12.46	-0.1%	1.230	1.187

[swertz]

+1

Verbatim backport of #40327

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1