Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL Phase 2 - Skip new ALCA step for Phase 2 ECAL development WFs #40378

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

thomreis
Copy link
Contributor

PR description:

After the ALCA step was introduced for Phase 2 WFs with #39858 the ecalDevel workflows with suffix .61 and .612 failed during the new step5 since the track collections were not produced in the reco step. Since these WFs are intended for ECAL reconstruction developments, the reconstruction of other subdetector collections is not complete.

This PR skips the ALCA step for the ecalDevel WFs.

PR validation:

WF 20034.61 now runs to completion with four steps only.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40378/33496

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

type ecal

@cmsbuild cmsbuild added the ecal label Dec 20, 2022
@thomreis
Copy link
Contributor Author

test parameters:

  • workflow = 20034.61
  • relvals_opt = --what cleanedupgrade

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c591a/29727/summary.html
COMMIT: 415c936
CMSSW: CMSSW_13_0_X_2022-12-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40378/29727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20034.61 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3558162
  • DQMHistoTests: Total failures: 154
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557986
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 165 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Technical PR to disable ALCA step for special ECAL workflow.

@kskovpen
Copy link
Contributor

kskovpen commented Jan 4, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 5, 2023

+1

@cmsbuild cmsbuild merged commit 278e21c into cms-sw:master Jan 5, 2023
@thomreis thomreis deleted the ecal-phase2-matrix-wf-fix branch January 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants