[L1T] update in Phase 2 jet event content

[epalencia]

PR description:

This PR changes with jet collections are produced in the standard L1 sequence, and are stored in the event content:

• 7x7 histogram puppi jets are removed
• 9x9trimmed histogram jets are added, 9x9 histogram jets are kept in
• Simulated seeded cone puppi jets are removed, keeping only the collection produced by emulation
• The HPS tau simulation/emulation are updated to use the 9x9trimmed jet instead of 7x7 jets.

Local PR: cms-l1t-offline#1062
The two commits in that original PR not ported here should be already in master.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40402/33524

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.

It involves the following packages:

• L1Trigger/Configuration (l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
• L1Trigger/Phase2L1Taus (l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a5ae/29758/summary.html
COMMIT: 3356f79
CMSSW: CMSSW_13_0_X_2022-12-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40402/29758/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 20834.76

----- Begin Fatal Exception 22-Dec-2022 16:54:42 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepFlavour_2p4'
   [2] Calling method for module L1TEnergySumFilter/'l1tPFPuppiHT400offMaxEta2p4'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::EtSum>
Looking for module label: l1tPhase1JetSumsProducer
Looking for productInstanceName: Sums

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

• 20834.75

----- Begin Fatal Exception 22-Dec-2022 17:01:14 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepFlavour_2p4'
   [2] Calling method for module L1TEnergySumFilter/'l1tPFPuppiHT400offMaxEta2p4'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<l1t::EtSum>
Looking for module label: l1tPhase1JetSumsProducer
Looking for productInstanceName: Sums

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

• 20834.7620834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33/step2_TTbar_14TeV+2026D88_HLTwDIGI75e33.log

[cecilecaillol]

@trtomei We would need to change the l1t inputs to the hlt code, as you can see from the error above. Can you do it or would you like us to take care of this?

[beaucero]

@cecilecaillol , If you could do it, it would be great... Thanks!

[epalencia]

I have added a couple of commits from @EmyrClement made in epalencia#1:

• The first commit replaces jet sums calculated from 7x7 jets to those calculated from 9x9trimmed jets (l1tPhase1JetSumsProducer -> l1tPhase1JetSumsProducer9x9trimmed).
• The second commit updates the HLT modules to consume the 9x9trimmed jets instead of the 9x9 jets.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40402/33849

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #40402 was updated. @Martin-Grunewald, @rekovic, @epalencia, @missirol, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

[epalencia]

Please test

[beaucero]

Okay for HLT-Upgrade

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a5ae/30126/summary.html
COMMIT: 782d8e4
CMSSW: CMSSW_13_0_X_2023-01-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40402/30126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555473
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[missirol]

+hlt

I note that there is a file in the HLT Phase-2 folder which defines a module called l1tPhase1JetCalibrator9x9 at

cmssw/HLTrigger/Configuration/python/HLT_75e33/modules/l1tSlwPFPuppiJetsCorrected_cfi.py

Line 3 in e7e8960

l1tPhase1JetCalibrator9x9 = cms.EDProducer("Phase1L1TJetCalibrator",

, but that file is not currently used in CMSSW.

[AdrianoDee]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1