Added removeSchedulingTokensFromModuleLabel function #40425

Dr15Jones · 2023-01-03T22:18:29Z

PR description:

Function removes tokens added by the framework to denote how to schedule a module.

PR validation:

Code compiles and new test passes.

fixes cms-sw/framework-team#458

Function removes tokens added by the framework to denote how to schedule a module.

Dr15Jones · 2023-01-03T22:19:19Z

please test

cmsbuild · 2023-01-03T22:25:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40425/33555

This PR adds an extra 16KB to repository

cmsbuild · 2023-01-03T22:25:36Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Utilities (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-01-04T02:26:01Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36007b/29795/summary.html
COMMIT: 06fbef4
CMSSW: CMSSW_13_0_X_2023-01-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40425/29795/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@civanch Minor cleanup of Geant4 physics configuration #40416

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36007b/29795/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36007b/29795/git-merge-result

RelVals-INPUT

140.6140.6_RunHI2022/step2_RunHI2022.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555726
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

Dr15Jones · 2023-01-04T14:55:49Z

please test

the test failure can't possibly come from this change as the new function isn't used anywhere but the new test.

makortel · 2023-01-04T15:08:55Z

It seems that the failed job ends up asking the data from Vanderbilt after attempt to access it from the IB cache fails

04-Jan-2023 00:39:14 CET  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root
%MSG-w XrdAdaptorInternal:  file_open 04-Jan-2023 00:39:15 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root?xrdcl.requuid=62e7d4d3-abbb-40d2-b69f-24c5a43a9206.
%MSG
%MSG-w XrdAdaptorInternal:  file_open 04-Jan-2023 00:39:15 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root?tried=&xrdcl.requuid=a12e51e9-4839-418a-b89b-1123957b6d58.
%MSG
04-Jan-2023 00:39:15 CET  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root
%MSG-w XrdAdaptorInternal:  file_open 04-Jan-2023 00:39:16 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root?xrdcl.requuid=c9036a9b-1bce-416c-b30c-803404fd26f0.
%MSG
%MSG-w XrdAdaptorInternal:  file_open 04-Jan-2023 00:39:16 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root?tried=&xrdcl.requuid=fe85f630-ac7a-4230-9313-48db105bc1b7.
%MSG
04-Jan-2023 00:39:16 CET  Initiating request to open file root://xrootd-cms.infn.it//store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root
04-Jan-2023 00:39:33 CET  Successfully opened file root://xrootd-cms.infn.it//store/hidata/HIRun2022A/HITestRawPrime0/RAW/v1/000/362/321/00000/fe35c38e-bcff-42e0-bf65-9f0f50d83382.root
%MSG-w XrdAdaptorLvl3:  AfterFile 04-Jan-2023 00:39:44 CET pre-events
Deactivating xrootd-se3-vanderbilt.sites.opensciencegrid.org from active sources because its quality (1420) is higher than 260 and 4 times larger than the other active server xrootd-se6-vanderbilt.sites.opensciencegrid.org (260) 
%MSG
%MSG-w XrdAdaptorLvl3:  AfterFile 04-Jan-2023 00:39:46 CET pre-events
Deactivating xrootd-se6-vanderbilt.sites.opensciencegrid.org from active sources because its quality (1076) is higher than 260 and 4 times larger than the other active server xrootd-se1-vanderbilt.sites.opensciencegrid.org (260) 
%MSG
[2023-01-04 00:43:23.981195 +0100][Error  ][AsyncSock         ] [xrootd-se1-vanderbilt.sites.opensciencegrid.org:1094.0] Socket error encountered: [ERROR] Socket error

I see the same happens also in IBs. I see the directory exists in the cache, but the file is indeed not there. @smuzaffar (or @cms-sw/externals-l2) could you check why this file does not end up being cached?

cmsbuild · 2023-01-04T18:58:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36007b/29797/summary.html
COMMIT: 06fbef4
CMSSW: CMSSW_13_0_X_2023-01-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40425/29797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 1188
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554538
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

makortel · 2023-01-04T21:06:51Z

Comparison differences are in 11364.7 (#39803 )

makortel · 2023-01-04T21:08:46Z

+1

cmsbuild · 2023-01-04T21:09:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-05T07:11:38Z

+1

smuzaffar · 2023-01-07T22:27:35Z

@Dr15Jones , GCC 12 is not happy with this change
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_13_0_X_2023-01-07-1100/FWCore/Utilities

FWCore/Utilities/src/path_configuration.cc:39:35: error: variable 'constexpr const std::array<char, 4> s_tokens' has initializer but incomplete type

perrotta · 2023-01-09T10:33:39Z

@Dr15Jones , GCC 12 is not happy with this change https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_13_0_X_2023-01-07-1100/FWCore/Utilities
FWCore/Utilities/src/path_configuration.cc:39:35: error: variable 'constexpr const std::array<char, 4> s_tokens' has initializer but incomplete type

@missirol suggests that it is enough adding the missing #include <array> in FWCore/Utilities/src/path_configuration.cc
It is missing, in fact: a possible fix in that sense is in #40452

Dr15Jones · 2023-01-09T14:05:08Z

@perotta thanks for making the change!

Added removeSchedulingTokensFromModuleLabel function

06fbef4

Function removes tokens added by the framework to denote how to schedule a module.

cmsbuild added this to the CMSSW_13_0_X milestone Jan 3, 2023

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Jan 3, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 3, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 3, 2023

cmsbuild added tests-rejected and removed tests-started labels Jan 4, 2023

cmsbuild added tests-started and removed tests-rejected labels Jan 4, 2023

makortel mentioned this pull request Jan 4, 2023

function to get module name from PSet without "decorations" #40007

Closed

missirol mentioned this pull request Jan 4, 2023

use removeSchedulingTokensFromModuleLabel in pat::TriggerObjectStandAlone #40428

Merged

cmsbuild added tests-approved and removed tests-started labels Jan 4, 2023

cmsbuild removed core-pending pending-signatures labels Jan 4, 2023

cmsbuild added core-approved fully-signed labels Jan 4, 2023

cmsbuild added orp-approved and removed orp-pending labels Jan 5, 2023

cmsbuild merged commit 1a989c3 into cms-sw:master Jan 5, 2023

makortel mentioned this pull request Jan 5, 2023

function to get module name from PSet without "decorations" cms-sw/framework-team#458

Closed

perrotta mentioned this pull request Jan 9, 2023

Add missing include in FWCore/Utilities/src/path_configuration.cc #40452

Merged

Dr15Jones deleted the stripTokensFromModuleLabels branch January 12, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added removeSchedulingTokensFromModuleLabel function #40425

Added removeSchedulingTokensFromModuleLabel function #40425

Dr15Jones commented Jan 3, 2023 •

edited

Dr15Jones commented Jan 3, 2023

cmsbuild commented Jan 3, 2023

cmsbuild commented Jan 3, 2023

cmsbuild commented Jan 4, 2023

Dr15Jones commented Jan 4, 2023

makortel commented Jan 4, 2023

cmsbuild commented Jan 4, 2023

makortel commented Jan 4, 2023

makortel commented Jan 4, 2023

cmsbuild commented Jan 4, 2023

perrotta commented Jan 5, 2023

smuzaffar commented Jan 7, 2023

perrotta commented Jan 9, 2023

Dr15Jones commented Jan 9, 2023

Added removeSchedulingTokensFromModuleLabel function #40425

Added removeSchedulingTokensFromModuleLabel function #40425

Conversation

Dr15Jones commented Jan 3, 2023 • edited

PR description:

PR validation:

Dr15Jones commented Jan 3, 2023

cmsbuild commented Jan 3, 2023

cmsbuild commented Jan 3, 2023

cmsbuild commented Jan 4, 2023

RelVals-INPUT

Comparison Summary

Dr15Jones commented Jan 4, 2023

makortel commented Jan 4, 2023

cmsbuild commented Jan 4, 2023

Comparison Summary

makortel commented Jan 4, 2023

makortel commented Jan 4, 2023

cmsbuild commented Jan 4, 2023

perrotta commented Jan 5, 2023

smuzaffar commented Jan 7, 2023

perrotta commented Jan 9, 2023

Dr15Jones commented Jan 9, 2023

Dr15Jones commented Jan 3, 2023 •

edited