[12_6_X] HCAL: make HBHE zero suppression simulation identical to the data-taking one for Run3

[abdoulline]

PR description:

Backport of #40444
In case TSG would need to use 12_6_X for 2023 MC studies with HCAL high-DC and corresponding (high-level) ZS conditions specially prepared for these studies.

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_12_6_X.

It involves the following packages:

• SimCalorimetry/HcalZeroSuppressionProducers (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @sameasy, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL: make HBHE zero suppression simulation identical to the data-taking one for Run3 #40444

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6911eb/29828/summary.html
COMMIT: ad1a404
CMSSW: CMSSW_12_6_X_2023-01-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40447/29828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5290 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3458651
• DQMHistoTests: Total failures: 1430
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3457199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[perrotta]

backport of #40444

[cmsbuild]

Pull request #40447 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6911eb/29833/summary.html
COMMIT: 754e53f
CMSSW: CMSSW_12_6_X_2023-01-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40447/29833/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5300 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3458651
• DQMHistoTests: Total failures: 1438
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3457191
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[abdoulline]

"ERROR TIMEOUT"...

[perrotta]

"ERROR TIMEOUT"...

Not an issue, then
Still; i would like to understand whether modifications to HCAL simulation can still be allowed for 12_6_X. Something we can discuss tomorrow at the ORP meeting

[abdoulline]

@perrotta I understand, as DIGI change (even small) is not welcomed in post-release patches...
But it'd be highly desirable for planned TSG studies for 2023 with 12_6_X, discussed at XC on Dec.16.
I'll try to attend the ORP meeting https://indico.cern.ch/event/1232089/ tomorrow...

[civanch]

please test

[srimanob]

please abort

Sorry @civanch, I need to add extra workflow to the test.

[srimanob]

test parameters:

[srimanob]

test parameters:

• workflows = 20834.101,23234.101
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

[srimanob]

@cmsbuild please test

The test include 1000fb-1, we should see no difference for this aging case.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6911eb/29899/summary.html
COMMIT: 754e53f
CMSSW: CMSSW_12_6_X_2023-01-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40447/29899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5293 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3647289
• DQMHistoTests: Total failures: 1433
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3645834
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 216 log files, 166 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• As discussed in the ORP meeting of Jan 10 (see minutes in https://indico.cern.ch/event/1232089/), this can be merged as such without any modifier in 12_6_X